Sign upLogin

pagseguro/magento2

View on GitHub
Star

Showing 385 of 385 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
Severity: Major
Found in Controller/Adminhtml/Transactions/Index.php and 3 other locations - About 3 hrs to fix
Controller/Adminhtml/Cancellation/Index.php on lines 1..73
Controller/Adminhtml/Conciliation/Index.php on lines 1..74
Controller/Adminhtml/Refund/Index.php on lines 1..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
Severity: Major
Found in Controller/Adminhtml/Conciliation/Index.php and 3 other locations - About 3 hrs to fix
Controller/Adminhtml/Cancellation/Index.php on lines 1..73
Controller/Adminhtml/Refund/Index.php on lines 1..74
Controller/Adminhtml/Transactions/Index.php on lines 1..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _fnBuildAjax has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function _fnBuildAjax(oSettings, data, fn) {
    // Compatibility with 1.9-, allow fnServerData and event to manipulate
    _fnCallbackFire(oSettings, 'aoServerParams', 'serverParams', [data]);

    // Convert to object based for 1.10+ if using the old array scheme which can
Severity: Major
Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        function b(b) {
        return this.each(function() {
            var d = a(this),
                e = d.data('bs.affix'),
                f = 'object' === typeof b && b;
    Severity: Major
    Found in view/frontend/web/js/bootstrap.min.js and 1 other location - About 3 hrs to fix
    view/frontend/web/js/bootstrap.min.js on lines 1407..1415

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        function c(c) {
        return this.each(function() {
            var d = a(this),
                e = d.data('bs.scrollspy'),
                f = 'object' === typeof c && c;
    Severity: Major
    Found in view/frontend/web/js/bootstrap.min.js and 1 other location - About 3 hrs to fix
    view/frontend/web/js/bootstrap.min.js on lines 1596..1604

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    DebitMethod has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DebitMethod
{
    /**
     * @var \Magento\Checkout\Model\Session
     */
    Severity: Minor
    Found in Model/Direct/DebitMethod.php - About 3 hrs to fix

      Function validateCnpj has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

      function validateCnpj(self) {
  var cnpj = unmask(self.value);
  var numbersVal;
  var digits;
  var sum;
      Severity: Minor
      Found in view/frontend/web/js/model/direct-payment-validator.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _fnSort has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function _fnSort(oSettings) {
    var i,
      ien,
      iLen,
      j,
      Severity: Major
      Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 3 hrs to fix

        File CreditCardMethod.php has 313 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
        Severity: Minor
        Found in Model/Direct/CreditCardMethod.php - About 3 hrs to fix

          BoletoMethod has 29 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class BoletoMethod implements Checkout
{
    /**
     * @var \Magento\Checkout\Model\Session
     */
          Severity: Minor
          Found in Model/Direct/BoletoMethod.php - About 3 hrs to fix

            Function _ has 84 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  _: function (settings, host, idx, buttons, page, pages) {
        var classes = settings.oClasses;
        var lang = settings.oLanguage.oPaginate;
        var aria = settings.oLanguage.oAria.paginate || {};
        var btnDisplay,
            Severity: Major
            Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 3 hrs to fix

              Function _fnAddOptionsHtml has 83 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function _fnAddOptionsHtml(oSettings) {
    var classes = oSettings.oClasses;
    var table = $(oSettings.nTable);
    var holding = $('<div/>').insertBefore(table); // Holding element for speed
    var features = oSettings.oFeatures;
              Severity: Major
              Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 3 hrs to fix

                Method getTitleCodePaymentMethod has 83 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function getTitleCodePaymentMethod($code)
    {
        if (!is_null($code)) {
            switch ($code) {
                case 101:
                Severity: Major
                Found in Helper/Data.php - About 3 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      function d(b) {
        return this.each(function() {
            var c = a(this),
                d = c.data('bs.dropdown');
            d || c.data('bs.dropdown', (d = new g(this))),
                  Severity: Major
                  Found in view/frontend/web/js/bootstrap.min.js and 1 other location - About 3 hrs to fix
                  view/frontend/web/js/bootstrap.min.js on lines 60..67

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      function b(b) {
        return this.each(function() {
            var c = a(this),
                e = c.data('bs.alert');
            e || c.data('bs.alert', (e = new d(this))),
                  Severity: Major
                  Found in view/frontend/web/js/bootstrap.min.js and 1 other location - About 3 hrs to fix
                  view/frontend/web/js/bootstrap.min.js on lines 562..569

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  File direct-payment-validator.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /**
 * 2007-2017 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
 *
                  Severity: Minor
                  Found in view/frontend/web/js/model/direct-payment-validator.js - About 3 hrs to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function __construct(
        \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfigInterface,
        \Magento\Framework\Model\ResourceModel\Db\Context $context,
        \Magento\Backend\Model\Session $session,
        \Magento\Sales\Model\Order $order,
                    Severity: Major
                    Found in Model/Transactions/Methods/Cancellation.php and 2 other locations - About 3 hrs to fix
                    Model/Transactions/Methods/Conciliation.php on lines 95..125
                    Model/Transactions/Methods/Refund.php on lines 95..126

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 143.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function __construct(
        \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfigInterface,
        \Magento\Framework\Model\ResourceModel\Db\Context $context,
        \Magento\Backend\Model\Session $session,
        \Magento\Sales\Model\Order $order,
                    Severity: Major
                    Found in Model/Transactions/Methods/Refund.php and 2 other locations - About 3 hrs to fix
                    Model/Transactions/Methods/Cancellation.php on lines 95..125
                    Model/Transactions/Methods/Conciliation.php on lines 95..125

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 143.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function __construct(
        \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfigInterface,
        \Magento\Framework\Model\ResourceModel\Db\Context $context,
        \Magento\Backend\Model\Session $session,
        \Magento\Sales\Model\Order $order,
                    Severity: Major
                    Found in Model/Transactions/Methods/Conciliation.php and 2 other locations - About 3 hrs to fix
                    Model/Transactions/Methods/Cancellation.php on lines 95..125
                    Model/Transactions/Methods/Refund.php on lines 95..126

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 143.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function _fnAjaxParameters has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      function _fnAjaxParameters(settings) {
    var columns = settings.aoColumns,
      columnCount = columns.length,
      features = settings.oFeatures,
      preSearch = settings.oPreviousSearch,
                    Severity: Major
                    Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 2 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language