Sign upLogin

pagseguro/magento2

View on GitHub
Star

Showing 385 of 385 total issues

Function _fnSortFlatten has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function _fnSortFlatten(settings) {
    var i,
      iLen,
      k,
      kLen,
Severity: Major
Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 2 hrs to fix

    Function run has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var run = function (s) {
      var selInt = _intVal(s);

      // Selector - all
      if (s === '') {
    Severity: Major
    Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 2 hrs to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            $.when(
        setPaymentInformationAction(this.messageContainer, {
          method: self.getCode(),
          additional_data: {
            boleto_document: self.boletoDocument()
      Severity: Major
      Found in view/frontend/web/js/view/payment/method-renderer/boleto-method.js and 2 other locations - About 2 hrs to fix
      view/frontend/web/js/view/payment/method-renderer/credit_card-method.js on lines 176..206
      view/frontend/web/js/view/payment/method-renderer/online_debit-method.js on lines 85..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            $.when(
        setPaymentInformationAction(messageContainer, {
          method: self.getCode(),
          additional_data: {
            credit_card_document: self.creditCardDocument()
      Severity: Major
      Found in view/frontend/web/js/view/payment/method-renderer/credit_card-method.js and 2 other locations - About 2 hrs to fix
      view/frontend/web/js/view/payment/method-renderer/boleto-method.js on lines 101..120
      view/frontend/web/js/view/payment/method-renderer/online_debit-method.js on lines 85..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            $.when(
        setPaymentInformationAction(this.messageContainer, {
          method: self.getCode(),
          additional_data: {
            online_debit_document: self.onlineDebitDocument()
      Severity: Major
      Found in view/frontend/web/js/view/payment/method-renderer/online_debit-method.js and 2 other locations - About 2 hrs to fix
      view/frontend/web/js/view/payment/method-renderer/boleto-method.js on lines 101..120
      view/frontend/web/js/view/payment/method-renderer/credit_card-method.js on lines 176..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function setPagSeguroDiscountsByPaymentMethod has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setPagSeguroDiscountsByPaymentMethod()
    {
        $storeId = \Magento\Store\Model\ScopeInterface::SCOPE_STORE;
        if ($this->_scopeConfig->getValue('payment/pagseguro_default_lightbox/discount_credit_card', $storeId)=== 1) {
            $creditCard = (double)$this->_scopeConfig->getValue('payment/pagseguro_default_lightbox/discount_credit_card_value', $storeId);
      Severity: Minor
      Found in Model/PaymentMethod.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _fnInitialise has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function _fnInitialise(settings) {
    var i,
      iLen,
      iAjaxStart = settings.iInitDisplayStart;
    var columns = settings.aoColumns,
      Severity: Major
      Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 2 hrs to fix

        Function run has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var run = function (s) {
      var fnSelector = typeof s === 'function';

      if (s === null || s === undefined || fnSelector) {
        // All cells and function selectors
        Severity: Major
        Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  $abandoned = new Abandoned(
            $this->_objectManager->create('Magento\Framework\App\Config\ScopeConfigInterface'),
            $this->_objectManager->create('Magento\Framework\App\ResourceConnection'),
            $this->_objectManager->create('Magento\Framework\Mail\Template\TransportBuilder'),
            $this->_objectManager->create('Magento\Framework\Model\ResourceModel\Db\Context'),
          Severity: Major
          Found in Controller/Adminhtml/Abandoned/Transport.php and 1 other location - About 2 hrs to fix
          Controller/Adminhtml/Abandoned/Request.php on lines 53..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  $abandoned = new Abandoned(
            $this->_objectManager->create('Magento\Framework\App\Config\ScopeConfigInterface'),
            $this->_objectManager->create('Magento\Framework\App\ResourceConnection'),
            $this->_objectManager->create('Magento\Framework\Mail\Template\TransportBuilder'),
            $this->_objectManager->create('Magento\Framework\Model\ResourceModel\Db\Context'),
          Severity: Major
          Found in Controller/Adminhtml/Abandoned/Request.php and 1 other location - About 2 hrs to fix
          Controller/Adminhtml/Abandoned/Transport.php on lines 51..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method setPagSeguroDiscountsByPaymentMethod has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function setPagSeguroDiscountsByPaymentMethod()
    {
        $storeId = \Magento\Store\Model\ScopeInterface::SCOPE_STORE;
        if ($this->_scopeConfig->getValue('payment/pagseguro_default_lightbox/discount_credit_card', $storeId)=== 1) {
            $creditCard = (double)$this->_scopeConfig->getValue('payment/pagseguro_default_lightbox/discount_credit_card_value', $storeId);
          Severity: Major
          Found in Model/PaymentMethod.php - About 2 hrs to fix

            Function init has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                (c.prototype.init = function(b, c, d) {
        if (
            ((this.enabled = !0),
                (this.type = b),
                (this.$element = a(c)),
            Severity: Minor
            Found in view/frontend/web/js/bootstrap.min.js - About 2 hrs to fix

              Function getMasked has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    getMasked: function (a, b) {
        var m = [],
          h = void 0 === b ? c.val() : b + '',
          f = 0,
          l = e.length,
              Severity: Minor
              Found in view/frontend/web/js/jquery.mask.min.js - About 2 hrs to fix

                Function jqueryui has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      jqueryui: function (settings, cell, column, classes) {
        $('<div/>')
          .addClass(classes.sSortJUIWrapper)
          .append(cell.contents())
          .append(
                Severity: Minor
                Found in view/adminhtml/web/js/jquery.dataTables.min.js - About 1 hr to fix

                  Method getTransactionTypeName has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function getTransactionTypeName($transactionTypeCode)
    {
        if ($transactionTypeCode) {
            switch ($transactionTypeCode) {
                case 1:
                  Severity: Minor
                  Found in Helper/Data.php - About 1 hr to fix

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        (a.fn.tooltip = b),
    (a.fn.tooltip.Constructor = c),
    (a.fn.tooltip.noConflict = function() {
        return (a.fn.tooltip = d), this;
    });
                    Severity: Major
                    Found in view/frontend/web/js/bootstrap.min.js and 3 other locations - About 1 hr to fix
                    view/frontend/web/js/bootstrap.min.js on lines 346..350
                    view/frontend/web/js/bootstrap.min.js on lines 1382..1386
                    view/frontend/web/js/bootstrap.min.js on lines 1582..1586

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 74.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        (a.fn.popover = b),
    (a.fn.popover.Constructor = c),
    (a.fn.popover.noConflict = function() {
        return (a.fn.popover = d), this;
    });
                    Severity: Major
                    Found in view/frontend/web/js/bootstrap.min.js and 3 other locations - About 1 hr to fix
                    view/frontend/web/js/bootstrap.min.js on lines 346..350
                    view/frontend/web/js/bootstrap.min.js on lines 1314..1318
                    view/frontend/web/js/bootstrap.min.js on lines 1582..1586

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 74.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        (a.fn.tab = b),
    (a.fn.tab.Constructor = c),
    (a.fn.tab.noConflict = function() {
        return (a.fn.tab = d), this;
    });
                    Severity: Major
                    Found in view/frontend/web/js/bootstrap.min.js and 3 other locations - About 1 hr to fix
                    view/frontend/web/js/bootstrap.min.js on lines 346..350
                    view/frontend/web/js/bootstrap.min.js on lines 1314..1318
                    view/frontend/web/js/bootstrap.min.js on lines 1382..1386

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 74.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        (a.fn.carousel = b),
    (a.fn.carousel.Constructor = c),
    (a.fn.carousel.noConflict = function() {
        return (a.fn.carousel = d), this;
    });
                    Severity: Major
                    Found in view/frontend/web/js/bootstrap.min.js and 3 other locations - About 1 hr to fix
                    view/frontend/web/js/bootstrap.min.js on lines 1314..1318
                    view/frontend/web/js/bootstrap.min.js on lines 1382..1386
                    view/frontend/web/js/bootstrap.min.js on lines 1582..1586

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 74.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function Search has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          Search: function (url) {
        jQuery
          .ajax({
            url: url + '/pagseguro/conciliation/request',
            data: {
                    Severity: Minor
                    Found in view/adminhtml/web/js/public.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language