palourde/uchiwa

View on GitHub
uchiwa/helpers/helpers.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function IsCheckSilenced has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

func IsCheckSilenced(check, client map[string]interface{}, dc string, silenced []interface{}) (bool, []string) {
    var isSilenced bool
    var commonSubscriptions, isSilencedBy, subscribers, subscriptions []string

    if dc == "" || len(silenced) == 0 {
Severity: Minor
Found in uchiwa/helpers/helpers.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function IsCheckSilenced has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func IsCheckSilenced(check, client map[string]interface{}, dc string, silenced []interface{}) (bool, []string) {
    var isSilenced bool
    var commonSubscriptions, isSilencedBy, subscribers, subscriptions []string

    if dc == "" || len(silenced) == 0 {
Severity: Major
Found in uchiwa/helpers/helpers.go - About 2 hrs to fix

    Function GetEvent has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func GetEvent(check, client, dc string, events *[]interface{}) (map[string]interface{}, error) {
        if check == "" || client == "" || dc == "" || len(*events) == 0 {
            return nil, errors.New("No parameters should be empty")
        }
    
    
    Severity: Minor
    Found in uchiwa/helpers/helpers.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function IsCheckSilenced has 5 return statements (exceeds 4 allowed).
    Open

    func IsCheckSilenced(check, client map[string]interface{}, dc string, silenced []interface{}) (bool, []string) {
        var isSilenced bool
        var commonSubscriptions, isSilencedBy, subscribers, subscriptions []string
    
        if dc == "" || len(silenced) == 0 {
    Severity: Major
    Found in uchiwa/helpers/helpers.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status