File server.go
has 1078 lines of code (exceeds 500 allowed). Consider refactoring. Open
package uchiwa
import (
"compress/gzip"
"crypto/tls"
Method Uchiwa.aggregateHandler
has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) aggregateHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead && r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.aggregateHandler
has 116 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) aggregateHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead && r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.clientHandler
has 94 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) clientHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodDelete && r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
Method Uchiwa.silencedHandler
has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) silencedHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /silenced
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.clientHandler
has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) clientHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodDelete && r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Uchiwa
has 23 methods (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) aggregateHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead && r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.aggregateHandler
has 22 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) aggregateHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead && r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.checkHandler
has 70 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) checkHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
Method Uchiwa.silencedHandler
has 68 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) silencedHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /silenced
Method Uchiwa.stashHandler
has 67 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) stashHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.resultsHandler
has 67 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) resultsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.eventHandler
has 67 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) eventHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.clientHandler
has 18 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) clientHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodDelete && r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
Method Uchiwa.checkHandler
has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) checkHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.checkHandler
has 13 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) checkHandler(w http.ResponseWriter, r *http.Request) {
// We only support DELETE & GET requests
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
Method Uchiwa.stashHandler
has 12 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) stashHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.silencedHandler
has 12 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) silencedHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /silenced
Method Uchiwa.resultsHandler
has 12 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) resultsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.eventHandler
has 12 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) eventHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.stashesHandler
has 51 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (u *Uchiwa) stashesHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /stashes
Method Uchiwa.clientsHandler
has 9 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) clientsHandler(w http.ResponseWriter, r *http.Request) {
// Support GET & HEAD requests
if r.Method == http.MethodGet || r.Method == http.MethodHead {
token := authentication.GetJWTFromContext(r)
Method Uchiwa.stashHandler
has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) stashHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.stashesHandler
has 8 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) stashesHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /stashes
Method Uchiwa.eventHandler
has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) eventHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.resultsHandler
has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) resultsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.datacenterHandler
has 6 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) datacenterHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.stashesHandler
has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring. Open
func (u *Uchiwa) stashesHandler(w http.ResponseWriter, r *http.Request) {
token := authentication.GetJWTFromContext(r)
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /stashes
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Uchiwa.datacentersHandler
has 5 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) datacentersHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.eventsHandler
has 5 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) eventsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.requestHandler
has 5 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) requestHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodPost {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.checksHandler
has 5 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) checksHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
Method Uchiwa.aggregatesHandler
has 5 return statements (exceeds 4 allowed). Open
func (u *Uchiwa) aggregatesHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (u *Uchiwa) resultsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 780.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (u *Uchiwa) eventHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodDelete {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 780.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (u *Uchiwa) aggregatesHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 418.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (u *Uchiwa) eventsHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 418.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (u *Uchiwa) checksHandler(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet && r.Method != http.MethodHead {
http.Error(w, "", http.StatusBadRequest)
return
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 418.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /silenced
u.Mu.RLock()
silenced := Filters.Silenced(&u.Data.Silenced, token)
u.Mu.RUnlock()
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 311.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if r.Method == http.MethodGet || r.Method == http.MethodHead {
// GET on /stashes
u.Mu.RLock()
stashes := Filters.Stashes(&u.Data.Stashes, token)
u.Mu.RUnlock()
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 311.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76