Sign upLogin

passworks/passworks-ruby

View on GitHub
Star
lib/passworks/faraday/http_exception_middleware.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method call has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def call(env)
        @app.call(env).on_complete do |response|
          case response[:status].to_i
          when 400
            raise Passworks::Exceptions::BadRequest, error_400(response)
Severity: Minor
Found in lib/passworks/faraday/http_exception_middleware.rb - About 1 hr to fix

    Method error_body has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def error_body(response)
          body = response[:body]
          # body gets passed as a string, not sure if it is passed as something else from other spots?
          if not body.nil? and not body.empty? and body.kind_of?(String)
            body = ::JSON.parse(body)
    Severity: Minor
    Found in lib/passworks/faraday/http_exception_middleware.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status