pauldix/sax-machine

View on GitHub
lib/sax-machine/handlers/sax_abstract_handler.rb

Summary

Maintainability
C
1 day
Test Coverage

Method _end_element has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def _end_element(name)
      name = normalize_name(name)

      start_tag = stack[-2]
      close_tag = stack[-1]
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method data_class_value has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def data_class_value(data_class, value)
      case data_class.to_s
      when "String"  then value != NO_BUFFER ? value.to_s : value
      when "Integer" then value != NO_BUFFER ? value.to_i : value
      when "Float"   then value != NO_BUFFER ? value.to_s.gsub(",",".").to_f : value
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _start_element has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def _start_element(name, attrs = [])
      name   = normalize_name(name)
      node   = stack.last
      object = node.object

Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _start_element has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def _start_element(name, attrs = [])
      name   = normalize_name(name)
      node   = stack.last
      object = node.object

Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

    Method _end_element has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def _end_element(name)
          name = normalize_name(name)
    
          start_tag = stack[-2]
          close_tag = stack[-1]
    Severity: Minor
    Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status