Sign upLogin

pboling/celluloid-io-pg-listener

View on GitHub
Star

Showing 351 of 351 total issues

Line is too long. [113/80]
Open

        # However, due to the nature of the initialize method we can't tell if we have a legitimate super or not.
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/async_listener.rb by rubocop

Line is too long. [104/80]
Open

        debug "Listening for notifications on #{dbname}:#{channel} with callback to #{@callback_method}"
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/async_listener.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  opts.on("-d", "--debug", "set $CELLULOID_DEBUG = true") do |file|
Severity: Minor
Found in bin/supervision by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  opts.on("-t", "--threaded", "set Celluloid.task_class = Celluloid::Task::Threaded") do |file|
Severity: Minor
Found in bin/supervision by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Avoid using {...} for multi-line blocks.
Open

    define_singleton_method(callback_method) {
Severity: Minor
Found in lib/celluloid-io-pg-listener/examples/double_super_example.rb by rubocop

Check for uses of braces or do/end around single line or multi-line blocks.

Example: EnforcedStyle: linecountbased (default)

# bad - single line block
items.each do |item| item / 5 end

# good - single line block
items.each { |item| item / 5 }

# bad - multi-line block
things.map { |thing|
  something = thing.some_method
  process(something)
}

# good - multi-line block
things.map do |thing|
  something = thing.some_method
  process(something)
end

Example: EnforcedStyle: semantic

# Prefer `do...end` over `{...}` for procedural blocks.

# return value is used/assigned
# bad
foo = map do |x|
  x
end
puts (map do |x|
  x
end)

# return value is not used out of scope
# good
map do |x|
  x
end

# Prefer `{...}` over `do...end` for functional blocks.

# return value is not used out of scope
# bad
each { |x|
  x
}

# return value is used/assigned
# good
foo = map { |x|
  x
}
map { |x|
  x
}.inspect

Example: EnforcedStyle: bracesforchaining

# bad
words.each do |word|
  word.flip.flop
end.join("-")

# good
words.each { |word|
  word.flip.flop
}.join("-")

Missing top-level class documentation comment.
Open

    class ListenerClientByInheritance < CelluloidIOPGListener::Examples::Client
Severity: Minor
Found in lib/celluloid-io-pg-listener/examples/listener_client_by_inheritance.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

              as: listener_config["as"],
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervision_configuration_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at module body beginning.
Open


      def self.included(base)
Severity: Minor
Found in lib/celluloid-io-pg-listener/unlisten_wrappers/with_termination.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Line is too long. [98/80]
Open

    #                     Named after, and structurally identical to, PG::Connection#conninfo_hash
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/client_extracted_signature.rb by rubocop

Extra empty line detected at module body end.
Open


end
Severity: Minor
Found in lib/celluloid-io-pg-listener.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Line is too long. [89/80]
Open

  #   At least that's my operating hypothesis, if anyone knows better please let me know.
Severity: Minor
Found in lib/celluloid-io-pg-listener.rb by rubocop

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in lib/celluloid-io-pg-listener/examples/double_super_example.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        if listener_config.delete("listener_active")
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervision_configuration_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Pass array contents as separate arguments.
Open

          block.call(*[
                         notification[:relname], # channel
                         notification[:be_pid], # pid
                         notification[:extra] # payload
                     ])
Severity: Minor
Found in lib/celluloid-io-pg-listener/client.rb by rubocop

This cop checks for unneeded usages of splat expansion

Example:

# bad

a = *[1, 2, 3]
a = *'a'
a = *1

begin
  foo
rescue *[StandardError, ApplicationError]
  bar
end

case foo
when *[1, 2, 3]
  bar
else
  baz
end

Example:

# good

c = [1, 2, 3]
a = *c
a, b = *c
a, *b = *c
a = *1..10
a = ['a']

begin
  foo
rescue StandardError, ApplicationError
  bar
end

case foo
when *[1, 2, 3]
  bar
else
  baz
end

Line is too long. [84/80]
Open

      base.send(:prepend, CelluloidIOPGListener::Initialization::ArgumentExtraction)
Severity: Minor
Found in lib/celluloid-io-pg-listener/client.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  VERSION = "0.3.2"
Severity: Minor
Found in lib/celluloid-io-pg-listener/version.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at module body beginning.
Open


      # 2nd initialize override invoked
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/async_listener.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Line is too long. [88/80]
Open

      # @callback_method  - Name of the method to be called when notifications are heard
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/async_listener.rb by rubocop

Missing top-level module documentation comment.
Open

    module AsyncListener
Severity: Minor
Found in lib/celluloid-io-pg-listener/initialization/async_listener.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

1 trailing blank lines detected.
Open

Severity: Minor
Found in Gemfile by rubocop
Severity
Category
Status
Source
Language