pboling/rack-insight

View on GitHub

Showing 116 of 116 total issues

File jquery-1.3.2.js has 3038 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery JavaScript Library v1.3.2
 * http://jquery.com/
 *
 * Copyright (c) 2009 John Resig
Severity: Major
Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 wk to fix

    Function ajax has 163 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ajax: function( s ) {
            // Extend the settings, but re-extend 's' so that it can be
            // checked again later (in the test suite, specifically)
            s = jQuery.extend(true, s, jQuery.extend(true, {}, jQuery.ajaxSettings, s));
    
    
    Severity: Major
    Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 6 hrs to fix

      Function SHA1 has 130 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      document.SHA1 = function(msg) {
        function rotate_left(n,s) {
          var t4 = ( n<<s ) | (n>>>(32-s));
          return t4;
        };
      Severity: Major
      Found in lib/rack/insight/public/__insight__/bookmarklet.js - About 5 hrs to fix

        Function SHA1 has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

        document.SHA1 = function(msg) {
          function rotate_left(n,s) {
            var t4 = ( n<<s ) | (n>>>(32-s));
            return t4;
          };
        Severity: Minor
        Found in lib/rack/insight/public/__insight__/bookmarklet.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if ( typeof elem === "string" ) {
                        // Fix "XHTML"-style tags in all browsers
                        elem = elem.replace(/(<(\w+)[^>]*?)\/>/g, function(all, front, tag){
                            return tag.match(/^(abbr|br|col|img|input|link|meta|param|hr|area|embed)$/i) ?
                                all :
        Severity: Critical
        Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 4 hrs to fix

          Class Panel has 31 methods (exceeds 20 allowed). Consider refactoring.
          Open

            class Panel
              include ERB::Util
              include Rack::Insight::Logging
              include Rack::Insight::Render
              include Rack::Insight::Database::RequestDataClient
          Severity: Minor
          Found in lib/rack/insight/panel.rb - About 3 hrs to fix

            Function Sizzle has 93 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var Sizzle = function(selector, context, results, seed) {
                results = results || [];
                context = context || document;
            
                if ( context.nodeType !== 1 && context.nodeType !== 9 )
            Severity: Major
            Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 3 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  for( i=60; i<=79; i++ ) {
                    temp = (rotate_left(A,5) + (B ^ C ^ D) + E + W[i] + 0xCA62C1D6) & 0x0ffffffff;
                    E = D;
                    D = C;
                    C = rotate_left(B,30);
              Severity: Major
              Found in lib/rack/insight/public/__insight__/bookmarklet.js and 1 other location - About 3 hrs to fix
              lib/rack/insight/public/__insight__/bookmarklet.js on lines 134..141

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  for( i=20; i<=39; i++ ) {
                    temp = (rotate_left(A,5) + (B ^ C ^ D) + E + W[i] + 0x6ED9EBA1) & 0x0ffffffff;
                    E = D;
                    D = C;
                    C = rotate_left(B,30);
              Severity: Major
              Found in lib/rack/insight/public/__insight__/bookmarklet.js and 1 other location - About 3 hrs to fix
              lib/rack/insight/public/__insight__/bookmarklet.js on lines 152..159

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method content_for_request has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
              Open

                  def content_for_request(number)
                    logger.info("Rack::Insight is using default content_for_request for #{self.class}") if verbose(:med)
                    if !self.has_table?
                      logger.info("#{self.class} is being used without a table") if verbose(:med)
                      content
              Severity: Minor
              Found in lib/rack/insight/panel.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method decode_message has 84 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def decode_message(m)
                        @m = m.clone
                        params = ActiveSupport::OrderedHash.new
              
                        # Mode, Limits
              Severity: Major
              Found in lib/rack/insight/panels/sphinx_panel/stats.rb - About 3 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                if ( document.documentElement["getBoundingClientRect"] )
                    jQuery.fn.offset = function() {
                        if ( !this[0] ) return { top: 0, left: 0 };
                        if ( this[0] === this[0].ownerDocument.body ) return jQuery.offset.bodyOffset( this[0] );
                        var box  = this[0].getBoundingClientRect(), doc = this[0].ownerDocument, body = doc.body, docElem = doc.documentElement,
                Severity: Critical
                Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 3 hrs to fix

                  Method current_panel_file has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def current_panel_file(sub)
                          file_name = nil
                          matched_line = nil
                          caller.each do |line|
                            # First make sure we are not matching rack-insight's own panel class, which will be in the caller stack,
                  Severity: Minor
                  Found in lib/rack/insight/panel.rb - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function clean has 72 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      clean: function( elems, context, fragment ) {
                          context = context || document;
                  
                          // !context.createElement fails in IE with an error but returns typeof 'object'
                          if ( typeof context.createElement === "undefined" )
                  Severity: Major
                  Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 2 hrs to fix

                    Consider simplifying this complex logical expression.
                    Open

                            if ( event.pageX == null && event.clientX != null ) {
                                var doc = document.documentElement, body = document.body;
                                event.pageX = event.clientX + (doc && doc.scrollLeft || body && body.scrollLeft || 0) - (doc.clientLeft || 0);
                                event.pageY = event.clientY + (doc && doc.scrollTop || body && body.scrollTop || 0) - (doc.clientTop || 0);
                            }
                    Severity: Critical
                    Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 2 hrs to fix

                      Function filter has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      Sizzle.filter = function(expr, set, inplace, not){
                          var old = expr, result = [], curLoop = set, match, anyFound,
                              isXMLFilter = set && set[0] && isXML(set[0]);
                      
                          while ( expr && set.length ) {
                      Severity: Major
                      Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 2 hrs to fix

                        Function attr has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            attr: function( elem, name, value ) {
                                // don't set attributes on text and comment nodes
                                if (!elem || elem.nodeType == 3 || elem.nodeType == 8)
                                    return undefined;
                        
                        
                        Severity: Major
                        Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 2 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              stopPropagation: function() {
                                  this.isPropagationStopped = returnTrue;
                          
                                  var e = this.originalEvent;
                                  if( !e )
                          Severity: Major
                          Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js and 1 other location - About 2 hrs to fix
                          lib/rack/insight/public/__insight__/jquery-1.3.2.js on lines 2830..2841

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 76.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              preventDefault: function() {
                                  this.isDefaultPrevented = returnTrue;
                          
                                  var e = this.originalEvent;
                                  if( !e )
                          Severity: Major
                          Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js and 1 other location - About 2 hrs to fix
                          lib/rack/insight/public/__insight__/jquery-1.3.2.js on lines 2842..2853

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 76.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function remove has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              remove: function(elem, types, handler) {
                                  // don't do events on text and comment nodes
                                  if ( elem.nodeType == 3 || elem.nodeType == 8 )
                                      return;
                          
                          
                          Severity: Minor
                          Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language