pboling/rack-insight

View on GitHub

Showing 116 of 116 total issues

Function val has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    val: function( value ) {
        if ( value === undefined ) {
            var elem = this[0];

            if ( elem ) {
Severity: Minor
Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      $('#rack-insight ul.panels li a').on('click', function() {
          $.insight.panel_id = this.className
          $.insight.switchCurrentPanel()
          $.insight.toggleCurrent()
          return false;
    Severity: Major
    Found in lib/rack/insight/public/__insight__/insight.js and 1 other location - About 1 hr to fix
    lib/rack/insight/public/__insight__/insight.js on lines 84..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      $('#rack-insight .panel_content .rack-insight_close').on('click', function() {
          $.insight.panel_id = this.id
          $.insight.switchCurrentPanel()
          $.insight.toggleCurrent()
          return false;
    Severity: Major
    Found in lib/rack/insight/public/__insight__/insight.js and 1 other location - About 1 hr to fix
    lib/rack/insight/public/__insight__/insight.js on lines 78..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method root_for_backtrace_filtering has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.root_for_backtrace_filtering(sub_path = nil)
          if defined?(Rails) && Rails.respond_to?(:root)
            sub_path ? Rails.root.join(sub_path) : Rails.root
          else
            root = if defined?(RAILS_ROOT)
    Severity: Minor
    Found in lib/rack/insight/filtered_backtrace.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function trigger has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        trigger: function( event, data, elem, bubbling ) {
            // Event object or event type
            var type = event.type || event;
    
            if( !bubbling ){
    Severity: Minor
    Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

      Function onreadystatechange has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              var onreadystatechange = function(isTimeout){
                  // The request was aborted, clear the interval and decrement jQuery.active
                  if (xhr.readyState == 0) {
                      if (ival) {
                          // clear poll interval
      Severity: Minor
      Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

        Function animate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            animate: function( prop, speed, easing, callback ) {
                var optall = jQuery.speed(speed, easing, callback);
        
                return this[ optall.queue === false ? "each" : "queue" ](function(){
        
        
        Severity: Minor
        Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

          Method heading_for_request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              def heading_for_request(number)
                if !self.has_table?
                  heading
                else
                  num = count(number)
          Severity: Minor
          Found in lib/rack/insight/panel.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function add has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              add: function(elem, types, handler, data) {
                  if ( elem.nodeType == 3 || elem.nodeType == 8 )
                      return;
          
                  // For whatever reason, IE has trouble passing the window object
          Severity: Minor
          Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

            Function CHILD has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    CHILD: function(elem, match){
                        var type = match[1], node = elem;
                        switch (type) {
                            case 'only':
                            case 'first':
            Severity: Minor
            Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

              Function dirCheck has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function dirCheck( dir, cur, doneName, checkSet, nodeCheck, isXML ) {
                  var sibDir = dir == "previousSibling" && !isXML;
                  for ( var i = 0, l = checkSet.length; i < l; i++ ) {
                      var elem = checkSet[i];
                      if ( elem ) {
              Severity: Minor
              Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                Function curCSS has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    curCSS: function( elem, name, force ) {
                        var ret, style = elem.style;
                
                        // We need to handle opacity special in IE
                        if ( name == "opacity" && !jQuery.support.opacity ) {
                Severity: Minor
                Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                  Function load has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      load: function( url, params, callback ) {
                          if ( typeof url !== "string" )
                              return this._load( url );
                  
                          var off = url.indexOf(" ");
                  Severity: Minor
                  Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                    Consider simplifying this complex logical expression.
                    Open

                                if ( match[1] == "nth" ) {
                                    // parse equations like 'even', 'odd', '5', '2n', '3n+2', '4n-1', '-n+6'
                                    var test = /(-?)(\d*)n((?:\+|-)?\d*)/.exec(
                                        match[2] == "even" && "2n" || match[2] == "odd" && "2n+1" ||
                                        !/\D/.test( match[2] ) && "0n+" + match[2] || match[2]);
                    Severity: Critical
                    Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                      Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          def initialize(app)
                            if panel_app
                              #XXX use mappings
                              @app = Rack::Cascade.new([panel_app, app])
                            else
                      Severity: Minor
                      Found in lib/rack/insight/panel.rb - About 1 hr to fix

                        Function step has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            step: function(gotoEnd){
                                var t = now();
                        
                                if ( gotoEnd || t >= this.options.duration + this.startTime ) {
                                    this.now = this.end;
                        Severity: Minor
                        Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                          Function init has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              init: function( selector, context ) {
                                  // Make sure that a selection was provided
                                  selector = selector || document;
                          
                                  // Handle $(DOMElement)
                          Severity: Minor
                          Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                            Method short_string has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def short_string(item, max_per_elem = 50)
                                    begin
                                      string = item.inspect
                                      if string.length > max_per_elem
                                        case item
                            Severity: Minor
                            Found in lib/rack/insight/panels/speedtracer_panel/tracer.rb - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function offset has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                jQuery.fn.offset = function() {
                                    if ( !this[0] ) return { top: 0, left: 0 };
                                    if ( this[0] === this[0].ownerDocument.body ) return jQuery.offset.bodyOffset( this[0] );
                                    jQuery.offset.initialized || jQuery.offset.initialize();
                            
                            
                            Severity: Minor
                            Found in lib/rack/insight/public/__insight__/jquery-1.3.2.js - About 1 hr to fix

                              Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  def initialize(app)
                                    @app = app
                                    @uuid = UUIDTools::UUID.random_create.to_s
                                    table_setup("speedtracer", "uuid")
                                    key_sql_template("'%s'")
                              Severity: Minor
                              Found in lib/rack/insight/panels/speedtracer_panel.rb - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language