Sign upLogin

pedromsantos/glenn

View on GitHub
Star
src/__test__/Domain/Counterpoint.test.ts

Summary

Maintainability
A
0 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

  test('invalid note (leap to big)', () => {
    const counterPoint = new MelodicLine([
      new Note(Pitch.B, Duration.Whole, Octave.C5),
      new Note(Pitch.C, Duration.Whole, Octave.C5),
    ]);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 1 other location - About 1 day to fix
src/__test__/Domain/Counterpoint.test.ts on lines 60..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 205.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

  test('invalid note (repeated)', () => {
    const counterPoint = new MelodicLine([
      new Note(Pitch.C, Duration.Whole, Octave.C3),
      new Note(Pitch.C, Duration.Whole, Octave.C3),
    ]);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 1 other location - About 1 day to fix
src/__test__/Domain/Counterpoint.test.ts on lines 85..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 205.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Wontfix

  test('invalid note (not in range)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C5)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C4)]);
    const parts = createCounterpointParts(counterPoint, cantusFirmus, [ScaleDegree.I], Voice.Bass);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 3 other locations - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 110..122
src/__test__/Domain/Counterpoint.test.ts on lines 124..136
src/__test__/Domain/Counterpoint.test.ts on lines 138..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Wontfix

  test('invalid interval (Major Seventh)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.B, Duration.Whole, Octave.C2)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C2)]);
    const parts = createCounterpointParts(
      counterPoint,
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 3 other locations - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 46..58
src/__test__/Domain/Counterpoint.test.ts on lines 110..122
src/__test__/Domain/Counterpoint.test.ts on lines 124..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Wontfix

  test('invalid interval (Major Second)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.D, Duration.Whole, Octave.C4)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C4)]);
    const parts = createCounterpointParts(counterPoint, cantusFirmus, [ScaleDegree.I], Voice.Bass);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 3 other locations - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 46..58
src/__test__/Domain/Counterpoint.test.ts on lines 124..136
src/__test__/Domain/Counterpoint.test.ts on lines 138..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Wontfix

  test('invalid interval (Perfect Fourth)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.F, Duration.Whole, Octave.C5)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C5)]);
    const parts = createCounterpointParts(counterPoint, cantusFirmus, [ScaleDegree.I], Voice.Tenor);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 3 other locations - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 46..58
src/__test__/Domain/Counterpoint.test.ts on lines 110..122
src/__test__/Domain/Counterpoint.test.ts on lines 138..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

  test('invalid note (not a chord tone)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.D, Duration.Whole, Octave.C3)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C3)]);
    const parts = createCounterpointParts(counterPoint, cantusFirmus, [ScaleDegree.I]);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 1 other location - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Wontfix

  test('invalid note (only whole notes)', () => {
    const counterPoint = new MelodicLine([new Note(Pitch.C, Duration.Half, Octave.C5)]);
    const cantusFirmus = new MelodicLine([new Note(Pitch.C, Duration.Whole, Octave.C5)]);
    const parts = createCounterpointParts(counterPoint, cantusFirmus, [ScaleDegree.I]);
Severity: Major
Found in src/__test__/Domain/Counterpoint.test.ts and 1 other location - About 6 hrs to fix
src/__test__/Domain/Counterpoint.test.ts on lines 32..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status