Sign upLogin

petr-muller/pyff

View on GitHub
Star
pyff/imports.py

Summary

Maintainability
B
4 hrs
Test Coverage

File imports.py has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""This module contains code that handles comparing imports"""

import collections.abc
import types
from typing import Set, Dict, Union, Optional, FrozenSet, Mapping, cast
Severity: Minor
Found in pyff/imports.py - About 3 hrs to fix

    Function canonical_ast has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def canonical_ast(self) -> Union[ast.Name, ast.Attribute]:
        """Returns AST node for the full name

        Example: For 'join' imported by 'from os.path import join', returns AST of 'os.path.join'"""
        node: Union[ast.Name, ast.Attribute]
    Severity: Minor
    Found in pyff/imports.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status