petrsvihlik/WopiHost

View on GitHub

Showing 38 of 38 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public bool DisableAsync
    {
        get => Convert.ToBoolean(this["DISABLE_ASYNC"], CultureInfo.InvariantCulture);
        set => this["DISABLE_ASYNC"] = value.ToString(CultureInfo.InvariantCulture);
    }
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public bool Recording
    {
        get => Convert.ToBoolean(this["RECORDING"], CultureInfo.InvariantCulture);
        set => this["RECORDING"] = value.ToString(CultureInfo.InvariantCulture);
    }
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public bool Embedded
    {
        get => Convert.ToBoolean(this["EMBEDDED"], CultureInfo.InvariantCulture);
        set => this["EMBEDDED"] = value.ToString(CultureInfo.InvariantCulture);
    }
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public bool Fullscreen
    {
        get => Convert.ToBoolean(this["FULLSCREEN"], CultureInfo.InvariantCulture);
        set => this["FULLSCREEN"] = value.ToString(CultureInfo.InvariantCulture);
    }
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    public int Perfstats
    {
        get => Convert.ToInt32(this["PERFSTATS"], CultureInfo.InvariantCulture);
        set => this["PERFSTATS"] = value.ToString(CultureInfo.InvariantCulture);
    }
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

                            return new OkResult();
Severity: Major
Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                            return ReturnLockMismatch(Response, reason: "File not locked");
    Severity: Major
    Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return false;
      Severity: Major
      Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return new OkResult();
        Severity: Major
        Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return LockOrRefresh(newLock, existingLock);
          Severity: Major
          Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return ReturnLockMismatch(Response, existingLock.Lock);
            Severity: Major
            Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                          return ReturnLockMismatch(Response, reason: "File not locked");
              Severity: Major
              Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return true;
                Severity: Major
                Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new ConflictResult();
                  Severity: Major
                  Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return false;
                    Severity: Major
                    Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return ReturnLockMismatch(Response, reason: "File not locked");
                      Severity: Major
                      Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return new OkResult();
                        Severity: Major
                        Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                      return ReturnLockMismatch(Response, existingLock.Lock);
                          Severity: Major
                          Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language