Sign upLogin

petrsvihlik/WopiHost

View on GitHub
Star

Showing 38 of 38 total issues

Method ProcessLock has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

    public IActionResult ProcessLock(string id)
    {
        string oldLock = Request.Headers[WopiHeaders.OLD_LOCK];
        string newLock = Request.Headers[WopiHeaders.LOCK];
Severity: Minor
Found in src/WopiHost.Core/Controllers/FilesController.cs - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ProcessLock has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public IActionResult ProcessLock(string id)
    {
        string oldLock = Request.Headers[WopiHeaders.OLD_LOCK];
        string newLock = Request.Headers[WopiHeaders.LOCK];
Severity: Major
Found in src/WopiHost.Core/Controllers/FilesController.cs - About 4 hrs to fix

    Method GetRootContainer has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        [HttpPost]
    [Produces(MediaTypeNames.Application.Json)]
    public IActionResult GetRootContainer() //TODO: fix the path
    {
        var authorizationHeader = HttpContext.Request.Headers.Authorization;
    Severity: Major
    Found in src/WopiHost.Core/Controllers/WopiBootstrapperController.cs - About 2 hrs to fix

      Method GetCheckFileInfo has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static CheckFileInfo GetCheckFileInfo(this IWopiFile file, ClaimsPrincipal principal, HostCapabilities capabilities)
    {
        ArgumentNullException.ThrowIfNull(file);

        ArgumentNullException.ThrowIfNull(capabilities);
      Severity: Major
      Found in src/WopiHost.Core/FileExtensions.cs - About 2 hrs to fix

        Method HandleAuthenticateAsync has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected override Task<AuthenticateResult> HandleAuthenticateAsync()
    {
        try
        {
            //TODO: implement access_token_ttl https://msdn.microsoft.com/en-us/library/hh695362(v=office.12).aspx
        Severity: Minor
        Found in src/WopiHost.Core/Security/Authentication/AccessTokenHandler.cs - About 1 hr to fix

          Method GetCobaltFile has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private CobaltFile GetCobaltFile(IWopiFile file, ClaimsPrincipal principal)
    {
        var disposal = new DisposalEscrow(file.Owner);
        var content = new CobaltFilePartitionConfig
        {
          Severity: Minor
          Found in src/WopiHost.Cobalt/CobaltSession.cs - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var query = (await GetAppsAsync()).Where(e => e.Descendants(ElementAction).Any(d => (string)d.Attribute(AttrActionExtension) == extension)).Select(e => e.Attribute(AttrAppFavicon).Value);
            Severity: Major
            Found in src/WopiHost.Discovery/WopiDiscoverer.cs and 1 other location - About 1 hr to fix
            src/WopiHost.Discovery/WopiDiscoverer.cs on lines 107..107

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var query = (await GetAppsAsync()).Where(e => e.Descendants(ElementAction).Any(d => (string)d.Attribute(AttrActionExtension) == extension)).Select(e => e.Attribute(AttrAppName).Value);
            Severity: Major
            Found in src/WopiHost.Discovery/WopiDiscoverer.cs and 1 other location - About 1 hr to fix
            src/WopiHost.Discovery/WopiDiscoverer.cs on lines 115..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method EnumerateChildren has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                [HttpGet("{id}/children")]
    [Produces(MediaTypeNames.Application.Json)]
    public Container EnumerateChildren(string id)
    {
        var container = new Container();
            Severity: Minor
            Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 1 hr to fix

              Method Index has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public async Task<ActionResult> Index()
    {
        try
        {
            var files = StorageProvider.GetWopiFiles(StorageProvider.RootContainerPointer.Identifier);
              Severity: Minor
              Found in src/WopiHost.Web/Controllers/HomeController.cs - About 1 hr to fix

                Method ExecuteResultAsync has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public override async Task ExecuteResultAsync(ActionContext context)
    {
        var response = context.HttpContext.Response;
        response.ContentType = ContentType;
        var targetStream = response.Body;
                Severity: Minor
                Found in src/WopiHost.Core/Results/FileResult.cs - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var query = (await GetAppsAsync()).Elements().Where(e => (string)e.Attribute(AttrActionExtension) == extension && e.Attribute(AttrActionName).Value.Equals(actionString, StringComparison.InvariantCultureIgnoreCase)).Select(e => e.Attribute(AttrActionRequires).Value.Split(','));
                  Severity: Minor
                  Found in src/WopiHost.Discovery/WopiDiscoverer.cs and 1 other location - About 50 mins to fix
                  src/WopiHost.Discovery/WopiDiscoverer.cs on lines 100..100

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var query = (await GetAppsAsync()).Elements().Where(e => (string)e.Attribute(AttrActionExtension) == extension && e.Attribute(AttrActionName).Value.Equals(actionString, StringComparison.InvariantCultureIgnoreCase)).Select(e => e.Attribute(AttrActionUrl).Value);
                  Severity: Minor
                  Found in src/WopiHost.Discovery/WopiDiscoverer.cs and 1 other location - About 50 mins to fix
                  src/WopiHost.Discovery/WopiDiscoverer.cs on lines 84..84

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 78.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          var coauth = new CobaltFilePartitionConfig
        {
            IsNewFile = true,
            HostBlobStore = new TemporaryHostBlobStore(new TemporaryHostBlobStore.Config(), disposal, file.Identifier + @".CoauthMetadata"),
            cellSchemaIsGenericFda = false,
                  Severity: Major
                  Found in src/WopiHost.Cobalt/CobaltSession.cs and 2 other locations - About 45 mins to fix
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 12..20
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 32..40

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          var content = new CobaltFilePartitionConfig
        {
            IsNewFile = true,
            HostBlobStore = new TemporaryHostBlobStore(new TemporaryHostBlobStore.Config(), disposal, file.Identifier + @".Content"),
            cellSchemaIsGenericFda = true,
                  Severity: Major
                  Found in src/WopiHost.Cobalt/CobaltSession.cs and 2 other locations - About 45 mins to fix
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 22..30
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 32..40

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          var wacupdate = new CobaltFilePartitionConfig
        {
            IsNewFile = true,
            HostBlobStore = new TemporaryHostBlobStore(new TemporaryHostBlobStore.Config(), disposal, file.Identifier + @".WordWacUpdate"),
            cellSchemaIsGenericFda = false,
                  Severity: Major
                  Found in src/WopiHost.Cobalt/CobaltSession.cs and 2 other locations - About 45 mins to fix
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 12..20
                  src/WopiHost.Cobalt/CobaltSession.cs on lines 22..30

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                      public bool DisableBroadcast
    {
        get => Convert.ToBoolean(this["DISABLE_BROADCAST"], CultureInfo.InvariantCulture);
        set => this["DISABLE_BROADCAST"] = value.ToString(CultureInfo.InvariantCulture);
    }
                  Severity: Major
                  Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                      public int ThemeId
    {
        get => Convert.ToInt32(this["THEME_ID"], CultureInfo.InvariantCulture);
        set => this["THEME_ID"] = value.ToString(CultureInfo.InvariantCulture);
    }
                  Severity: Major
                  Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                      public int BusinessUser
    {
        get => Convert.ToInt32(this["BUSINESS_USER"], CultureInfo.InvariantCulture);
        set => this["BUSINESS_USER"] = value.ToString(CultureInfo.InvariantCulture);
    }
                  Severity: Major
                  Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                      public int DisableChat
    {
        get => Convert.ToInt32(this["DISABLE_CHAT"], CultureInfo.InvariantCulture);
        set => this["DISABLE_CHAT"] = value.ToString(CultureInfo.InvariantCulture);
    }
                  Severity: Major
                  Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
                  src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language