src/WopiHost.Core/Controllers/FilesController.cs
Method ProcessLock has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring. Open
Open
public IActionResult ProcessLock(string id)
{
string oldLock = Request.Headers[WopiHeaders.OLD_LOCK];
string newLock = Request.Headers[WopiHeaders.LOCK];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method ProcessLock has 111 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public IActionResult ProcessLock(string id)
{
string oldLock = Request.Headers[WopiHeaders.OLD_LOCK];
string newLock = Request.Headers[WopiHeaders.LOCK];
Avoid too many return statements within this method. Open
Open
return new OkResult();Avoid too many return statements within this method. Open
Open
return ReturnLockMismatch(Response, reason: "File not locked");Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return new OkResult();Avoid too many return statements within this method. Open
Open
return LockOrRefresh(newLock, existingLock);Avoid too many return statements within this method. Open
Open
return ReturnLockMismatch(Response, existingLock.Lock);Avoid too many return statements within this method. Open
Open
return ReturnLockMismatch(Response, reason: "File not locked");Avoid too many return statements within this method. Open
Open
return true;Avoid too many return statements within this method. Open
Open
return new ConflictResult();Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return ReturnLockMismatch(Response, reason: "File not locked");Avoid too many return statements within this method. Open
Open
return new OkResult();Avoid too many return statements within this method. Open
Open
return ReturnLockMismatch(Response, existingLock.Lock);