.phan/plugins/InvalidVariableIssetPlugin.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method visitIsset has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function visitIsset(Node $node): Context
    {
        $argument = $node->children['var'];
        $variable = $argument;

Severity: Major
Found in .phan/plugins/InvalidVariableIssetPlugin.php - About 2 hrs to fix

    Function visitIsset has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function visitIsset(Node $node): Context
        {
            $argument = $node->children['var'];
            $variable = $argument;
    
    
    Severity: Minor
    Found in .phan/plugins/InvalidVariableIssetPlugin.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $this->context;
    Severity: Major
    Found in .phan/plugins/InvalidVariableIssetPlugin.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->context;
      Severity: Major
      Found in .phan/plugins/InvalidVariableIssetPlugin.php - About 30 mins to fix

        The method visitIsset() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
        Open

            public function visitIsset(Node $node): Context
            {
                $argument = $node->children['var'];
                $variable = $argument;
        
        

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        There are no issues that match your filters.

        Category
        Status