Sign upLogin

phossa2/db

View on GitHub
Star
src/Db/Driver/Mysqli/Result.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getOneRow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getOneRow()
    {
        if ($this->bindResult()) {
            if ($this->statement->fetch()) {
                $row = [];
Severity: Minor
Found in src/Db/Driver/Mysqli/Result.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The 'getFields()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    protected function getFields()/*# : bool */
    {
        if (null === $this->cols) {
            $result = $this->statement->result_metadata();
            if (false === $result) {
Severity: Minor
Found in src/Db/Driver/Mysqli/Result.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

There are no issues that match your filters.

Category
Status