Sign upLogin

phplrt/phplrt

View on GitHub
Star

Showing 408 of 408 total issues

The method print has a boolean flag argument $multiline, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function print(mixed $data, bool $multiline = true): string;
Severity: Minor
Found in libs/compiler/src/Printer/PrinterInterface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '55', column '19').
Open

        throw new \BadMethodCallException(self::class . ' objects are immutable');
Severity: Minor
Found in libs/lexer/src/Token/Composite.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 68.
Open

    public function getStream()
    {
        if (!\is_resource($this->stream)) {
            $this->stream = \fopen($this->temp, 'rb+');
Severity: Minor
Found in libs/source/src/Source.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '16', column '34').
Open

            default => throw new \InvalidArgumentException(\sprintf(
Severity: Minor
Found in libs/compiler/src/Printer/PhpPrinter.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 192.
Open

    private function assertValid(string $pattern, array $modifiers, string $original = null): void
    {
        \error_clear_last();

        $flags = \PREG_SET_ORDER | \PREG_OFFSET_CAPTURE;
Severity: Minor
Found in libs/lexer/src/Runtime/Compiler.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '59', column '20').
Open

        return new \ErrorException(
Severity: Minor
Found in libs/source/src/Exception/NotReadableException.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 73.
Open

    public function getStream()
    {
        if (!\is_resource($this->stream)) {
            $this->stream = \fopen($this->temp, 'rb+');
Severity: Minor
Found in libs/source/src/Source.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '24', column '30').
Open

        $this->compose = new \WeakMap();
Severity: Minor
Found in libs/parser/src/Middleware/Pipeline.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '46', column '23').
Open

            throw new \LogicException(\vsprintf($message, [
Severity: Minor
Found in libs/position/src/PositionFactoryTrait.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 150.
Open

    public function __serialize(): array
    {
        \error_clear_last();

        $meta = @\stream_get_meta_data($this->stream);
Severity: Minor
Found in libs/source/src/Stream.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method __construct has a boolean flag argument $keep, which is a certain sign of a Single Responsibility Principle violation.
Open

        public bool $keep = true,
Severity: Minor
Found in libs/compiler/src/Node/Definition/TokenDefinitionNode.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Function createFromOffset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function createFromOffset(
        ReadableInterface $source,
        int $offset = PositionInterface::MIN_OFFSET
    ): Position {
        if ($offset <= PositionInterface::MIN_OFFSET) {
Severity: Minor
Found in libs/position/src/PositionFactory.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method traverseNode() has an NPath complexity of 239. The configured NPath complexity threshold is 200.
Open

    protected function traverseNode(NodeInterface $node): NodeInterface
    {
        foreach ($node as $name => $child) {
            if (\is_array($child)) {
                $this->updateNodeValue($node, $name, $this->traverseArray($child));
Severity: Minor
Found in libs/visitor/src/Executor.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method traverseArray() has an NPath complexity of 945. The configured NPath complexity threshold is 200.
Open

    protected function traverseArray(array $nodes): array
    {
        $replacements = [];

        foreach ($nodes as $i => &$node) {
Severity: Minor
Found in libs/visitor/src/Executor.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused parameters such as '$nodes'.
Open

    public function after(iterable $nodes): ?iterable
Severity: Minor
Found in libs/visitor/src/Visitor.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method traverseArray() has 102 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    protected function traverseArray(array $nodes): array
    {
        $replacements = [];

        foreach ($nodes as $i => &$node) {
Severity: Minor
Found in libs/visitor/src/Executor.php by phpmd

Avoid assigning values to variables in if clauses and the like (line '192', column '32').
Open

    public function lex(ReadableInterface $source, int $offset = 0, int $length = null): iterable
    {
        assert($offset >= 0, 'Offset value must be non-negative');
        assert($length === null || $length > 0, 'Length value must be greater than 0');
Severity: Minor
Found in libs/lexer/src/Lexer.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '149', column '18').
Open

    private function before(iterable $nodes): iterable
    {
        foreach ($this->visitors as $visitor) {
            if (($result = $visitor->before($nodes)) !== null) {
                $nodes = $result;
Severity: Minor
Found in libs/visitor/src/Executor.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$nodes'.
Open

    public function before(iterable $nodes): ?iterable
Severity: Minor
Found in libs/visitor/src/Visitor.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$node'.
Open

    public function leave(NodeInterface $node)
Severity: Minor
Found in libs/visitor/src/Visitor.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language