Sign upLogin

pietervogelaar/chef-cookbook-jenkins-server

View on GitHub
Star

Showing 171 of 171 total issues

Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    unless Chef::Config[:solo]
Severity: Minor
Found in recipes/slaves_credentials.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Final newline missing.
Open

end
Severity: Minor
Found in recipes/nginx.rb by rubocop

Line is too long. [103/80]
Open

template "#{node['nginx']['dir']}/sites-available/#{node['jenkins-server']['nginx']['server_name']}" do
Severity: Minor
Found in recipes/nginx.rb by rubocop

Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

  unless Chef::Config[:solo]
Severity: Minor
Found in recipes/plugins.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Avoid the use of the case equality operator ===.
Open

if plugin['markup'] === 'safe_html'
Severity: Minor
Found in recipes/plugin_antisamy-markup-formatter.rb by rubocop

This cop checks for uses of the case equality operator(===).

Example:

# bad
Array === something
(1..100) === 7
/something/ === some_string

# good
something.is_a?(Array)
(1..100).include?(7)
some_string =~ /something/

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      if slave.key?('description') then description slave['description'] end
Severity: Minor
Found in recipes/slaves.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      if slave.key?('labels') then labels slave['labels'] end
Severity: Minor
Found in recipes/slaves.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      if slave.key?('java_path') then java_path slave['java_path'] end
Severity: Minor
Found in recipes/slaves.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Line is too long. [90/80]
Open

# Set the private key in the run state only if security was enabled in a previous chef run
Severity: Minor
Found in recipes/security.rb by rubocop

Line is too long. [83/80]
Open

# By default Jenkins allows everybody. Configure "Project Matrix Authorization" and
Severity: Minor
Found in recipes/security.rb by rubocop

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem kitchen-vagrant should appear before test-kitchen.
Open

gem "kitchen-vagrant"
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  puts ">>>>> Kitchen gem not loaded, omitting tasks" unless ENV["CI"]
Severity: Minor
Found in Thorfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [115/80]
Open

# to further customize this resource, copy it into your own recipe and name it "configure custom crowd permissions"
Severity: Minor
Found in recipes/security.rb by rubocop

Line is too long. [91/80]
Open

# Set the jenkins_security_enabled flag and set run_state to use the configured private key
Severity: Minor
Found in recipes/security.rb by rubocop

Use meaningful heredoc delimiters.
Open

  EOH
Severity: Minor
Found in recipes/user.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

Unnecessary utf-8 encoding comment.
Open

# encoding: utf-8
Severity: Minor
Found in Thorfile by rubocop

Line is too long. [85/80]
Open

# Copy home folder skeleton files from /etc/skel, because the Jenkins package install
Severity: Minor
Found in recipes/user.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  puts ">>>>> Kitchen gem not loaded, omitting tasks" unless ENV["CI"]
Severity: Minor
Found in Thorfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer {...} over do...end for single-line blocks.
Open

  block do end
Severity: Minor
Found in recipes/security.rb by rubocop

Check for uses of braces or do/end around single line or multi-line blocks.

Example: EnforcedStyle: linecountbased (default)

# bad - single line block
items.each do |item| item / 5 end

# good - single line block
items.each { |item| item / 5 }

# bad - multi-line block
things.map { |thing|
  something = thing.some_method
  process(something)
}

# good - multi-line block
things.map do |thing|
  something = thing.some_method
  process(something)
end

Example: EnforcedStyle: semantic

# Prefer `do...end` over `{...}` for procedural blocks.

# return value is used/assigned
# bad
foo = map do |x|
  x
end
puts (map do |x|
  x
end)

# return value is not used out of scope
# good
map do |x|
  x
end

# Prefer `{...}` over `do...end` for functional blocks.

# return value is not used out of scope
# bad
each { |x|
  x
}

# return value is used/assigned
# good
foo = map { |x|
  x
}
map { |x|
  x
}.inspect

Example: EnforcedStyle: bracesforchaining

# bad
words.each do |word|
  word.flip.flop
end.join("-")

# good
words.each { |word|
  word.flip.flop
}.join("-")

Convert if nested inside else to elsif.
Open

  if node['dev_mode']
Severity: Minor
Found in recipes/security.rb by rubocop

If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

Example:

# bad
if condition_a
  action_a
else
  if condition_b
    action_b
  else
    action_c
  end
end

# good
if condition_a
  action_a
elsif condition_b
  action_b
else
  action_c
end
Severity
Category
Status
Source
Language