Sign upLogin

pietervogelaar/chef-cookbook-jenkins-server

View on GitHub
Star

Showing 171 of 171 total issues

Space inside } missing.
Open

  'pmd' => {'version' => '3.41'},
Severity: Minor
Found in attributes/default.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

gem "test-kitchen"
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Space inside { missing.
Open

  'xunit' => {'version' => '1.96'},
Severity: Minor
Found in attributes/default.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Line is too long. [104/80]
Open

default['jenkins-server']['settings']['executors'] = node['cpu']['total'] < 2 ? 2 : node['cpu']['total']
Severity: Minor
Found in attributes/default.rb by rubocop

Line is too long. [95/80]
Open

    'PATH' => "$PATH:/usr/local/bin:#{node['jenkins']['master']['home']}/.composer/vendor/bin",
Severity: Minor
Found in attributes/default.rb by rubocop

Use meaningful heredoc delimiters.
Open

  EOH
Severity: Minor
Found in recipes/views.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

4 trailing blank lines detected.
Open

Severity: Minor
Found in recipes/plugin_antisamy-markup-formatter.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

    :filter_result => {
      node['jenkins-server']['slaves']['search_key'] => [node['jenkins-server']['slaves']['search_key']],
    }
Severity: Minor
Found in recipes/slaves.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [82/80]
Open

      'public_key' => node['jenkins-server']['dev_mode']['security']['public_key']
Severity: Minor
Found in recipes/security.rb by rubocop

Line is too long. [83/80]
Open

    node['jenkins-server']['plugins']['crowd2']['group'].split(',').each do |group|
Severity: Minor
Found in recipes/security.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  puts ">>>>> Kitchen gem not loaded, omitting tasks" unless ENV["CI"]
Severity: Minor
Found in Thorfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language