Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Console/Commands/FixUsernames.php

Summary

Maintainability
A
0 mins
Test Coverage

Function restrictedCheck has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Invalid

    protected function restrictedCheck()
    {
        $affected = collect([]);

        $restricted = RestrictedNames::get();
Severity: Minor
Found in app/Console/Commands/FixUsernames.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restrictedCheck has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    protected function restrictedCheck()
    {
        $affected = collect([]);

        $restricted = RestrictedNames::get();
Severity: Major
Found in app/Console/Commands/FixUsernames.php - About 2 hrs to fix

    Function versionZeroTenNineFix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Invalid

        protected function versionZeroTenNineFix()
    {
        $profiles = Profile::whereNotNull('domain')
            ->whereNull('private_key')
            ->where('username', 'not like', '@%@%')
    Severity: Minor
    Found in app/Console/Commands/FixUsernames.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status