Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Console/Commands/InstanceManager.php

Summary

Maintainability
F
5 days
Test Coverage

Method handle has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $action = select(
            'What action do you want to perform?',
            [
Severity: Minor
Found in app/Console/Commands/InstanceManager.php - About 1 hr to fix

    Method banInstance has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function banInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
    Severity: Minor
    Found in app/Console/Commands/InstanceManager.php - About 1 hr to fix

      Method unlistInstance has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function unlistInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
      Severity: Minor
      Found in app/Console/Commands/InstanceManager.php - About 1 hr to fix

        Method relistInstance has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function relistInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
        Severity: Minor
        Found in app/Console/Commands/InstanceManager.php - About 1 hr to fix

          Method unbanInstance has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function unbanInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
          Severity: Minor
          Found in app/Console/Commands/InstanceManager.php - About 1 hr to fix

            Function handle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handle()
    {
        $action = select(
            'What action do you want to perform?',
            [
            Severity: Minor
            Found in app/Console/Commands/InstanceManager.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return $this->relistInstance();
            Severity: Major
            Found in app/Console/Commands/InstanceManager.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->unbanInstance();
              Severity: Major
              Found in app/Console/Commands/InstanceManager.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->banInstance();
                Severity: Major
                Found in app/Console/Commands/InstanceManager.php - About 30 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function unlistInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
                  Severity: Major
                  Found in app/Console/Commands/InstanceManager.php and 3 other locations - About 1 day to fix
                  app/Console/Commands/InstanceManager.php on lines 142..180
                  app/Console/Commands/InstanceManager.php on lines 182..220
                  app/Console/Commands/InstanceManager.php on lines 222..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function relistInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
                  Severity: Major
                  Found in app/Console/Commands/InstanceManager.php and 3 other locations - About 1 day to fix
                  app/Console/Commands/InstanceManager.php on lines 102..140
                  app/Console/Commands/InstanceManager.php on lines 182..220
                  app/Console/Commands/InstanceManager.php on lines 222..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function banInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
                  Severity: Major
                  Found in app/Console/Commands/InstanceManager.php and 3 other locations - About 1 day to fix
                  app/Console/Commands/InstanceManager.php on lines 102..140
                  app/Console/Commands/InstanceManager.php on lines 142..180
                  app/Console/Commands/InstanceManager.php on lines 222..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function unbanInstance()
    {
        $id = search(
            'Search by domain',
            fn (string $value) => strlen($value) > 0
                  Severity: Major
                  Found in app/Console/Commands/InstanceManager.php and 3 other locations - About 1 day to fix
                  app/Console/Commands/InstanceManager.php on lines 102..140
                  app/Console/Commands/InstanceManager.php on lines 142..180
                  app/Console/Commands/InstanceManager.php on lines 182..220

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status