Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Console/Commands/MediaS3GarbageCollector.php

Summary

Maintainability
C
1 day
Test Coverage

Function regularMode has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    protected function regularMode($minId, $limit, $log)
    {
        $gc = Media::whereRemoteMedia(false)
            ->whereNotNull(['status_id', 'cdn_url', 'replicated_at'])
            ->whereNot('version', '4')
Severity: Minor
Found in app/Console/Commands/MediaS3GarbageCollector.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method regularMode has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function regularMode($minId, $limit, $log)
    {
        $gc = Media::whereRemoteMedia(false)
            ->whereNotNull(['status_id', 'cdn_url', 'replicated_at'])
            ->whereNot('version', '4')
Severity: Major
Found in app/Console/Commands/MediaS3GarbageCollector.php - About 2 hrs to fix

    Method hugeMode has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function hugeMode($minId, $limit, $log)
    {
        $cloudDisk = Storage::disk(config('filesystems.cloud'));
        $localDisk = Storage::disk('local');
    Severity: Minor
    Found in app/Console/Commands/MediaS3GarbageCollector.php - About 1 hr to fix

      Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle()
    {
        $enabled = (bool) config_cache('pixelfed.cloud_storage');
        if(!$enabled) {
            $this->error('Cloud storage not enabled. Exiting...');
      Severity: Minor
      Found in app/Console/Commands/MediaS3GarbageCollector.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return $hugeMode ?
            $this->hugeMode($minId, $limit, $log) :
            $this->regularMode($minId, $limit, $log);
        Severity: Major
        Found in app/Console/Commands/MediaS3GarbageCollector.php - About 30 mins to fix

          Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function handle()
    {
        $enabled = (bool) config_cache('pixelfed.cloud_storage');
        if(!$enabled) {
            $this->error('Cloud storage not enabled. Exiting...');
          Severity: Minor
          Found in app/Console/Commands/MediaS3GarbageCollector.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status