Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/Admin/AdminDirectoryController.php

Summary

Maintainability
D
2 days
Test Coverage

File AdminDirectoryController.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\PixelfedDirectoryController;
Severity: Minor
Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 5 hrs to fix

    Method directoryInitialData has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function directoryInitialData(Request $request)
    {
        $res = [];

        $res['countries'] = collect((new ISO3166)->all())->pluck('name');
    Severity: Major
    Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 4 hrs to fix

      Function directoryInitialData has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function directoryInitialData(Request $request)
    {
        $res = [];

        $res['countries'] = collect((new ISO3166)->all())->pluck('name');
      Severity: Minor
      Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method directoryStore has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function directoryStore(Request $request)
    {
        $this->validate($request, [
            'location' => 'string|min:1|max:53',
            'summary' => 'string|nullable|max:140',
      Severity: Major
      Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 2 hrs to fix

        Method directoryHandleServerSubmission has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function directoryHandleServerSubmission(Request $request)
    {
        $reqs = [];
        $reqs['feature_config'] = [
            'open_registration' => (bool) config_cache('pixelfed.open_registration'),
        Severity: Minor
        Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 1 hr to fix

          Method directoryDeleteBannerImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function directoryDeleteBannerImage(Request $request)
    {
        $bannerImage = ConfigCache::whereK('app.banner_image')->first();
        $directory = ConfigCache::whereK('pixelfed.directory')->first();
        if (! $bannerImage && ! $directory || empty($directory->v)) {
          Severity: Minor
          Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                    return $res;
            Severity: Major
            Found in app/Http/Controllers/Admin/AdminDirectoryController.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      $res['feature_config'] = [
            'media_types' => Str::of(config_cache('pixelfed.media_types'))->explode(','),
            'image_quality' => config_cache('pixelfed.image_quality'),
            'optimize_image' => (bool) config_cache('pixelfed.optimize_image'),
            'max_photo_size' => config_cache('pixelfed.max_photo_size'),
              Severity: Major
              Found in app/Http/Controllers/Admin/AdminDirectoryController.php and 1 other location - About 3 hrs to fix
              app/Http/Controllers/PixelfedDirectoryController.php on lines 102..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 151.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function validVal($res, $val, $count = false, $minLen = false)
    {
        if (! isset($res[$val])) {
            return false;
        }
              Severity: Major
              Found in app/Http/Controllers/Admin/AdminDirectoryController.php and 1 other location - About 1 hr to fix
              app/Http/Controllers/PixelfedDirectoryController.php on lines 162..177

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status