Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/AdminCuratedRegisterController.php

Summary

Maintainability
C
1 day
Test Coverage

Method apiActivityLog has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apiActivityLog(Request $request, $id)
    {
        $record = CuratedRegister::findOrFail($id);

        $res = collect([
Severity: Major
Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 3 hrs to fix

    File AdminCuratedRegisterController.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace App\Http\Controllers;

use App\Mail\CuratedRegisterAcceptUser;
    Severity: Minor
    Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 2 hrs to fix

      Method index has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function index(Request $request)
    {
        $this->validate($request, [
            'filter' => 'sometimes|in:open,all,awaiting,approved,rejected,responses',
            'sort' => 'sometimes|in:asc,desc',
      Severity: Minor
      Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 1 hr to fix

        Function apiActivityLog has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function apiActivityLog(Request $request, $id)
    {
        $record = CuratedRegister::findOrFail($id);

        $res = collect([
        Severity: Minor
        Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return $query->orderBy('id', $sort);
        Severity: Major
        Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $q->whereIsClosed(true)->whereIsApproved(true);
          Severity: Major
          Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $q->whereIsClosed(true)->whereIsRejected(true);
            Severity: Major
            Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return view('admin.curated-register.index', compact('records', 'filter'));
              Severity: Major
              Found in app/Http/Controllers/AdminCuratedRegisterController.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status