Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/AdminInviteController.php

Summary

Maintainability
F
4 days
Test Coverage

Method apiRegister has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apiRegister(Request $request)
    {
        $this->validate($request, [
            'token' => 'required',
            'username' => [
Severity: Major
Found in app/Http/Controllers/AdminInviteController.php - About 3 hrs to fix

    Method apiUsernameCheck has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function apiUsernameCheck(Request $request)
    {
        $this->validate($request, [
            'token' => 'required',
            'username' => 'required'
    Severity: Minor
    Found in app/Http/Controllers/AdminInviteController.php - About 1 hr to fix

      Method apiEmailCheck has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function apiEmailCheck(Request $request)
    {
        $this->validate($request, [
            'token' => 'required',
            'email' => 'required'
      Severity: Minor
      Found in app/Http/Controllers/AdminInviteController.php - About 1 hr to fix

        Function apiUsernameCheck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function apiUsernameCheck(Request $request)
    {
        $this->validate($request, [
            'token' => 'required',
            'username' => 'required'
        Severity: Minor
        Found in app/Http/Controllers/AdminInviteController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                                return $fail('Username cannot be used.');
        Severity: Major
        Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $fail('Username cannot be used.');
          Severity: Major
          Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return $fail('Username is invalid. Username must be alpha-numeric and may contain dashes (-), periods (.) and underscores (_).');
            Severity: Major
            Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return $fail('Email is invalid.');
              Severity: Major
              Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return response()->json($validator->errors(), 400);
                Severity: Major
                Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return redirect()->intended('/');
                  Severity: Major
                  Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return $fail('Username is invalid. Username must be alpha-numeric and may contain dashes (-), periods (.) and underscores (_).');
                    Severity: Major
                    Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return response()->json([]);
                      Severity: Major
                      Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return response()->json([], 400);
                        Severity: Major
                        Found in app/Http/Controllers/AdminInviteController.php - About 30 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  $usernameRules = [
            'required',
            'min:2',
            'max:15',
            'unique:users',
                          Severity: Major
                          Found in app/Http/Controllers/AdminInviteController.php and 1 other location - About 1 day to fix
                          app/Http/Controllers/Auth/RegisterController.php on lines 70..106

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 320.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                                      'username' => [
                'required',
                'min:2',
                'max:15',
                'unique:users',
                          Severity: Major
                          Found in app/Http/Controllers/AdminInviteController.php and 2 other locations - About 1 day to fix
                          app/Http/Controllers/Api/ApiV1Dot1Controller.php on lines 507..543
                          app/Http/Controllers/RemoteAuthController.php on lines 489..525

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 318.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status