pixelfed/pixelfed

View on GitHub
app/Http/Controllers/Api/ApiV1Dot1Controller.php

Summary

Maintainability
F
1 wk
Test Coverage

File ApiV1Dot1Controller.php has 766 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers\Api;

use Cache;
Severity: Major
Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 day to fix

    Function moderatePost has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
    Open

        public function moderatePost(Request $request, $id)
        {
            abort_if(!$request->user() || !$request->user()->token(), 403);
            abort_if($request->user()->is_admin != true, 403);
            abort_unless($request->user()->tokenCan('admin:write'), 403);
    Severity: Minor
    Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method moderatePost has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function moderatePost(Request $request, $id)
        {
            abort_if(!$request->user() || !$request->user()->token(), 403);
            abort_if($request->user()->is_admin != true, 403);
            abort_unless($request->user()->tokenCan('admin:write'), 403);
    Severity: Major
    Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 3 hrs to fix

      Method inAppRegistration has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function inAppRegistration(Request $request)
          {
              abort_if($request->user(), 404);
              abort_unless((bool) config_cache('pixelfed.open_registration'), 404);
              abort_unless((bool) config_cache('pixelfed.allow_app_registration'), 404);
      Severity: Major
      Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 3 hrs to fix

        Method report has 82 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function report(Request $request)
            {
                abort_if(!$request->user() || !$request->user()->token(), 403);
                abort_unless($request->user()->tokenCan('write'), 403);
        
        
        Severity: Major
        Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 3 hrs to fix

          ApiV1Dot1Controller has 23 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class ApiV1Dot1Controller extends Controller
          {
              protected $fractal;
          
              public function __construct()
          Severity: Minor
          Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 2 hrs to fix

            Method accountEmailsFromPixelfed has 62 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function accountEmailsFromPixelfed(Request $request)
                {
                    abort_if(!$request->user() || !$request->user()->token(), 403);
                    abort_unless($request->user()->tokenCan('read'), 403);
            
            
            Severity: Major
            Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 2 hrs to fix

              Function report has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function report(Request $request)
                  {
                      abort_if(!$request->user() || !$request->user()->token(), 403);
                      abort_unless($request->user()->tokenCan('write'), 403);
              
              
              Severity: Minor
              Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method inAppRegistrationConfirm has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function inAppRegistrationConfirm(Request $request)
                  {
                      abort_if($request->user(), 404);
                      abort_unless((bool) config_cache('pixelfed.open_registration'), 404);
                      abort_unless((bool) config_cache('pixelfed.allow_app_registration'), 404);
              Severity: Minor
              Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 hr to fix

                Method placesById has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function placesById(Request $request, $id, $slug)
                    {
                        abort_if(!$request->user() || !$request->user()->token(), 403);
                        abort_unless($request->user()->tokenCan('read'), 403);
                
                
                Severity: Minor
                Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 hr to fix

                  Method accountLoginActivity has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function accountLoginActivity(Request $request)
                      {
                          abort_if(!$request->user() || !$request->user()->token(), 403);
                          abort_unless($request->user()->tokenCan('read'), 403);
                  
                  
                  Severity: Minor
                  Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 hr to fix

                    Method accountChangePassword has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function accountChangePassword(Request $request)
                        {
                            abort_if(!$request->user() || !$request->user()->token(), 403);
                            abort_unless($request->user()->tokenCan('write'), 403);
                    
                    
                    Severity: Minor
                    Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 1 hr to fix

                      Avoid too many return statements within this method.
                      Open

                                  return $this->error("Cannot self report", 400, ["error_code" => "ERROR_NO_SELF_REPORTS"]);
                      Severity: Major
                      Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                return $fail('Username cannot be used.');
                        Severity: Major
                        Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return response()->json([
                                      'success' => true,
                                  ]);
                          Severity: Major
                          Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return $this->error("Duplicate report", 400, ["error_code" => "ERROR_REPORT_DUPLICATE"]);
                            Severity: Major
                            Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return $this->error("Invalid report type", 400, ["error_code" => "ERROR_REPORT_OBJECT_TYPE_INVALID"]);
                              Severity: Major
                              Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return $this->json($res);
                                Severity: Major
                                Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                          return $fail('Username is invalid. Must end with a letter or number.');
                                  Severity: Major
                                  Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return $this->json($res);
                                    Severity: Major
                                    Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                          return $this->error("Invalid object id", 400, ["error_code" => "ERROR_INVALID_OBJECT_ID"]);
                                      Severity: Major
                                      Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                                return $fail('Username is invalid. Username must be alpha-numeric and may contain dashes (-), periods (.) and underscores (_).');
                                        Severity: Major
                                        Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php - About 30 mins to fix

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                      'username' => [
                                                          'required',
                                                          'min:2',
                                                          'max:15',
                                                          'unique:users',
                                          Severity: Major
                                          Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php and 2 other locations - About 1 day to fix
                                          app/Http/Controllers/AdminInviteController.php on lines 152..188
                                          app/Http/Controllers/RemoteAuthController.php on lines 489..525

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 318.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                                      case 'post':
                                                          $object = Status::find($object_id);
                                                          if (!$object) {
                                                              return $this->error("Invalid object id", 400, ["error_code" => "ERROR_INVALID_OBJECT_ID"]);
                                                          }
                                          Severity: Minor
                                          Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php and 1 other location - About 45 mins to fix
                                          app/Http/Controllers/Api/ApiV1Dot1Controller.php on lines 126..137

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 96.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                                      case 'user':
                                                          $object = Profile::find($object_id);
                                                          if (!$object) {
                                                              return $this->error("Invalid object id", 400, ["error_code" => "ERROR_INVALID_OBJECT_ID"]);
                                                          }
                                          Severity: Minor
                                          Found in app/Http/Controllers/Api/ApiV1Dot1Controller.php and 1 other location - About 45 mins to fix
                                          app/Http/Controllers/Api/ApiV1Dot1Controller.php on lines 112..124

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 96.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          There are no issues that match your filters.

                                          Category
                                          Status