Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/CollectionController.php

Summary

Maintainability
D
1 day
Test Coverage

File CollectionController.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
Severity: Minor
Found in app/Http/Controllers/CollectionController.php - About 2 hrs to fix

    Method storeId has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function storeId(Request $request)
    {
        abort_if(!$request->user(), 403);

        $this->validate($request, [
    Severity: Minor
    Found in app/Http/Controllers/CollectionController.php - About 1 hr to fix

      Method getUserCollections has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getUserCollections(Request $request, int $id)
    {
        $user = $request->user();
        $pid = $user ? $user->profile_id : null;
        $follows = false;
      Severity: Minor
      Found in app/Http/Controllers/CollectionController.php - About 1 hr to fix

        Method deleteId has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function deleteId(Request $request)
    {
        abort_if(!$request->user(), 403);
        $this->validate($request, [
            'collection_id' => 'required|int|min:1|exists:collections,id',
        Severity: Minor
        Found in app/Http/Controllers/CollectionController.php - About 1 hr to fix

          Method getItems has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getItems(Request $request, int $id)
    {
        $user = $request->user();
        $collection = CollectionService::getCollection($id);
          Severity: Minor
          Found in app/Http/Controllers/CollectionController.php - About 1 hr to fix

            Function getUserCollections has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getUserCollections(Request $request, int $id)
    {
        $user = $request->user();
        $pid = $user ? $user->profile_id : null;
        $follows = false;
            Severity: Minor
            Found in app/Http/Controllers/CollectionController.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getItems has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getItems(Request $request, int $id)
    {
        $user = $request->user();
        $collection = CollectionService::getCollection($id);
            Severity: Minor
            Found in app/Http/Controllers/CollectionController.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getCollection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getCollection(Request $request, $id)
    {
        $user = $request->user();
        $collection = CollectionService::getCollection($id);
            Severity: Minor
            Found in app/Http/Controllers/CollectionController.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function show(Request $request, int $id)
    {
        $user = $request->user();
        $collection = CollectionService::getCollection($id);
        abort_if(!$collection, 404);
            Severity: Minor
            Found in app/Http/Controllers/CollectionController.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if($collection['published_at'] == null || $collection['visibility'] != 'public') {
            abort_unless($user, 404);
            if($user->profile_id != $collection['pid']) {
                if(!$user->is_admin) {
                    abort_if($collection['visibility'] != 'private', 404);
            Severity: Major
            Found in app/Http/Controllers/CollectionController.php and 1 other location - About 1 hr to fix
            app/Http/Controllers/CollectionController.php on lines 209..217

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if($collection['published_at'] == null || $collection['visibility'] != 'public') {
            abort_unless($user, 404);
            if($user->profile_id != $collection['pid']) {
                if(!$user->is_admin) {
                    abort_if($collection['visibility'] != 'private', 404);
            Severity: Major
            Found in app/Http/Controllers/CollectionController.php and 1 other location - About 1 hr to fix
            app/Http/Controllers/CollectionController.php on lines 187..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status