Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/LiveStreamController.php

Summary

Maintainability
D
2 days
Test Coverage

File LiveStreamController.php has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
Severity: Minor
Found in app/Http/Controllers/LiveStreamController.php - About 4 hrs to fix

    Method createStream has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createStream(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if(!$request->user(), 403);
    Severity: Minor
    Found in app/Http/Controllers/LiveStreamController.php - About 1 hr to fix

      Function parseStreamUrl has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseStreamUrl($url)
    {
        $name = null;
        $key = null;
        $query = parse_url($url, PHP_URL_QUERY);
      Severity: Minor
      Found in app/Http/Controllers/LiveStreamController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createStream has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createStream(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if(!$request->user(), 403);
      Severity: Minor
      Found in app/Http/Controllers/LiveStreamController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method clientBroadcastPublish has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function clientBroadcastPublish(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if($request->ip() != '127.0.0.1', 400);
        $key = $request->input('name');
      Severity: Minor
      Found in app/Http/Controllers/LiveStreamController.php - About 1 hr to fix

        Method addChatComment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function addChatComment(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if(!$request->user(), 403);
        Severity: Minor
        Found in app/Http/Controllers/LiveStreamController.php - About 1 hr to fix

          Function clientBroadcastPublish has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function clientBroadcastPublish(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if($request->ip() != '127.0.0.1', 400);
        $key = $request->input('name');
          Severity: Minor
          Found in app/Http/Controllers/LiveStreamController.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function pinChatComment(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if(!$request->user(), 403);
          Severity: Major
          Found in app/Http/Controllers/LiveStreamController.php and 1 other location - About 4 hrs to fix
          app/Http/Controllers/LiveStreamController.php on lines 316..335

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 165.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function unpinChatComment(Request $request)
    {
        abort_if(!config('livestreaming.enabled'), 400);
        abort_if(!$request->user(), 403);
          Severity: Major
          Found in app/Http/Controllers/LiveStreamController.php and 1 other location - About 4 hrs to fix
          app/Http/Controllers/LiveStreamController.php on lines 295..314

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 165.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status