Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/ProfileAliasController.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method store has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function store(Request $request)
    {
        $this->validate($request, [
            'acct' => 'required',
        ]);
Severity: Minor
Found in app/Http/Controllers/ProfileAliasController.php - About 1 hr to fix

    Function store has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function store(Request $request)
    {
        $this->validate($request, [
            'acct' => 'required',
        ]);
    Severity: Minor
    Found in app/Http/Controllers/ProfileAliasController.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return back()->with('status', 'Successfully added alias!');
    Severity: Major
    Found in app/Http/Controllers/ProfileAliasController.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status