Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/RemoteAuthController.php

Summary

Maintainability
F
5 days
Test Coverage

File RemoteAuthController.php has 605 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use App\Models\RemoteAuth;
Severity: Major
Found in app/Http/Controllers/RemoteAuthController.php - About 1 day to fix

    Method redirect has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function redirect(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
    Severity: Major
    Found in app/Http/Controllers/RemoteAuthController.php - About 3 hrs to fix

      Method handleSubmit has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handleSubmit(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
      Severity: Major
      Found in app/Http/Controllers/RemoteAuthController.php - About 2 hrs to fix

        Method sessionValidateUsername has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function sessionValidateUsername(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
        Severity: Minor
        Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

          Method accountToId has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function accountToId(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
          Severity: Minor
          Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

            Method sessionCheck has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function sessionCheck(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
            Severity: Minor
            Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

              Function accountToId has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function accountToId(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
              Severity: Minor
              Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getAuthDomains has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getAuthDomains(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
              Severity: Minor
              Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

                Method sessionGetMastodonData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function sessionGetMastodonData(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
                Severity: Minor
                Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

                  Function redirect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function redirect(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
                  Severity: Minor
                  Found in app/Http/Controllers/RemoteAuthController.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getAuthDomains has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getAuthDomains(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
                  Severity: Minor
                  Found in app/Http/Controllers/RemoteAuthController.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                          return response()->json($res);
                  Severity: Major
                  Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return response()->json([
            'code' => 200,
            'username' => $username,
            'exists' => $exists,
        ]);
                    Severity: Major
                    Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return [];
                      Severity: Major
                      Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                return $fail('Username is invalid. Username must be alpha-numeric and may contain dashes (-), periods (.) and underscores (_).');
                        Severity: Major
                        Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return [
            'code' => 200,
            'msg' => 'Success',
            'token' => $token,
        ];
                          Severity: Major
                          Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return response()->json($res);
                            Severity: Major
                            Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return response()->json($res);
                              Severity: Major
                              Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                        return $fail('Username is invalid. Username must be alpha-numeric and may contain dashes (-), periods (.) and underscores (_).');
                                Severity: Major
                                Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                          return $fail('Username cannot be used.');
                                  Severity: Major
                                  Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                    return;
                                    Severity: Major
                                    Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                              return $fail('Username cannot be used.');
                                      Severity: Major
                                      Found in app/Http/Controllers/RemoteAuthController.php - About 30 mins to fix

                                        Similar blocks of code found in 3 locations. Consider refactoring.
                                        Open

                                                    'username' => [
                'required',
                'min:2',
                'max:15',
                'unique:users,username',
                                        Severity: Major
                                        Found in app/Http/Controllers/RemoteAuthController.php and 2 other locations - About 1 day to fix
                                        app/Http/Controllers/Api/ApiV1Dot1Controller.php on lines 508..544
                                        app/Http/Controllers/AdminInviteController.php on lines 152..188

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 318.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                            public function onboarding(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
                                        Severity: Minor
                                        Found in app/Http/Controllers/RemoteAuthController.php and 1 other location - About 35 mins to fix
                                        app/Http/Controllers/RemoteAuthController.php on lines 22..36

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 92.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                            public function start(Request $request)
    {
        abort_unless((
            config_cache('pixelfed.open_registration') &&
            config('remote-auth.mastodon.enabled')
                                        Severity: Minor
                                        Found in app/Http/Controllers/RemoteAuthController.php and 1 other location - About 35 mins to fix
                                        app/Http/Controllers/RemoteAuthController.php on lines 239..253

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 92.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status