pixelfed/pixelfed

View on GitHub
app/Http/Controllers/ReportController.php

Summary

Maintainability
C
1 day
Test Coverage

Method formStore has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function formStore(Request $request)
    {
        $this->validate($request, [
            'report'  => 'required|alpha_dash',
            'type'    => 'required|alpha_dash',
Severity: Major
Found in app/Http/Controllers/ReportController.php - About 3 hrs to fix

    Function formStore has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function formStore(Request $request)
        {
            $this->validate($request, [
                'report'  => 'required|alpha_dash',
                'type'    => 'required|alpha_dash',
    Severity: Minor
    Found in app/Http/Controllers/ReportController.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return response()->json(200);
    Severity: Major
    Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return redirect('/timeline')->with('error', 'You cannot report your own content!');
      Severity: Major
      Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return redirect('/timeline')->with('status', 'Report successfully sent!');
        Severity: Major
        Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return redirect('/timeline')->with('error', 'You have already reported this!');
          Severity: Major
          Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return response()->json(200);
            Severity: Major
            Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return response()->json(200);
              Severity: Major
              Found in app/Http/Controllers/ReportController.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status