Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/Settings/HomeSettings.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function homeUpdate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function homeUpdate(Request $request)
    {
        $this->validate($request, [
            'name'    => 'nullable|string|max:'.config('pixelfed.max_name_length'),
            'bio'     => 'nullable|string|max:'.config('pixelfed.max_bio_length'),
Severity: Minor
Found in app/Http/Controllers/Settings/HomeSettings.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method homeUpdate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function homeUpdate(Request $request)
    {
        $this->validate($request, [
            'name'    => 'nullable|string|max:'.config('pixelfed.max_name_length'),
            'bio'     => 'nullable|string|max:'.config('pixelfed.max_bio_length'),
Severity: Major
Found in app/Http/Controllers/Settings/HomeSettings.php - About 2 hrs to fix

    Method emailUpdate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function emailUpdate(Request $request)
    {
        $this->validate($request, [
            'email'   => 'required|email|unique:users,email',
        ]);
    Severity: Minor
    Found in app/Http/Controllers/Settings/HomeSettings.php - About 1 hr to fix

      Method passwordUpdate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function passwordUpdate(Request $request)
    {
        $this->validate($request, [
        'current'                => 'required|string',
        'password'               => 'required|string',
      Severity: Minor
      Found in app/Http/Controllers/Settings/HomeSettings.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status