pixelfed/pixelfed

File StoryApiV1Controller.php has 440 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

namespace App\Http\Controllers\Stories;

use App\DirectMessage;

Method carousel has 99 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function carousel(Request $request)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);
        $pid = $request->user()->profile_id;

Method selfCarousel has 99 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function selfCarousel(Request $request)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);
        $pid = $request->user()->profile_id;

Method comment has 61 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function comment(Request $request)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);
        $this->validate($request, [
            'sid' => 'required',

Method add has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function add(Request $request)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);

        $this->validate($request, [

Method viewed has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function viewed(Request $request)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);

        $this->validate($request, [

Avoid too many return statements within this method.

Open

        return response()->json($res, 200, [], JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);

Avoid too many return statements within this method.

Open

        return response()->json($res, 200, [], JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);

Avoid too many return statements within this method.

Open

                return [
                    'id' => 'pfs:'.$profile['id'],
                    'user' => [
                        'id' => (string) $profile['id'],
                        'username' => $profile['username'],

Avoid too many return statements within this method.

Open

                    return [
                        'id' => (string) $s->id,
                        'type' => $s->type,
                        'src' => url(Storage::url($s->path)),
                        'duration' => $s->duration,

Avoid too many return statements within this method.

Open

                return [
                    'id' => 'pfs:'.$profile['id'],
                    'user' => [
                        'id' => (string) $profile['id'],
                        'username' => $profile['username'],

Avoid too many return statements within this method.

Open

                    return [
                        'id' => (string) $s->id,
                        'type' => $s->type,
                        'src' => url(Storage::url($s->path)),
                        'duration' => $s->duration,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $nodes = $s->map(function ($s) use ($pid) {
            $profile = AccountService::get($s->profile_id, true);
            if (! $profile || ! isset($profile['id'])) {
                return false;
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $nodes = $s->map(function ($s) use ($pid) {
            $profile = AccountService::get($s->profile_id, true);
            if (! $profile || ! isset($profile['id'])) {
                return false;
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (config('database.default') == 'pgsql') {
            $s = Cache::remember(self::RECENT_KEY.$pid, self::RECENT_TTL, function () use ($pid) {
                return Story::select('stories.*', 'followers.following_id')
                    ->leftJoin('followers', 'followers.following_id', 'stories.profile_id')
                    ->where('followers.profile_id', $pid)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (config('database.default') == 'pgsql') {
            $s = Cache::remember(self::RECENT_KEY.$pid, self::RECENT_TTL, function () use ($pid) {
                return Story::select('stories.*', 'followers.following_id')
                    ->leftJoin('followers', 'followers.following_id', 'stories.profile_id')
                    ->where('followers.profile_id', $pid)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function delete(Request $request, $id)
    {
        abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);

        $user = $request->user();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            $selfStories = Story::whereProfileId($pid)
                ->whereActive(true)
                ->get()
                ->map(function ($s) {
                    return [

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            $selfStories = Story::whereProfileId($pid)
                ->whereActive(true)
                ->get()
                ->map(function ($s) {
                    return [

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        if ($story->local) {
            $n = new Notification;
            $n->profile_id = $dm->to_id;
            $n->actor_id = $dm->from_id;
            $n->item_id = $dm->id;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $path = $photo->storePubliclyAs($storagePath, Str::random(random_int(2, 12)).'_'.Str::random(random_int(32, 35)).'_'.Str::random(random_int(1, 14)).'.'.$photo->extension());

• Read up
  Read up