Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Jobs/InboxPipeline/InboxWorker.php

Summary

Maintainability
D
2 days
Test Coverage

Function verifySignature has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function verifySignature($headers, $payload)
    {
        $body = $this->payload;
        $bodyDecoded = $payload;
        $signature = is_array($headers['signature']) ? $headers['signature'][0] : $headers['signature'];
Severity: Minor
Found in app/Jobs/InboxPipeline/InboxWorker.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verifySignature has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function verifySignature($headers, $payload)
    {
        $body = $this->payload;
        $bodyDecoded = $payload;
        $signature = is_array($headers['signature']) ? $headers['signature'][0] : $headers['signature'];
Severity: Major
Found in app/Jobs/InboxPipeline/InboxWorker.php - About 2 hrs to fix

    Method blindKeyRotation has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function blindKeyRotation($headers, $payload)
    {
        $signature = is_array($headers['signature']) ? $headers['signature'][0] : $headers['signature'];
        $date = is_array($headers['date']) ? $headers['date'][0] : $headers['date'];
        if(!$signature) {
    Severity: Minor
    Found in app/Jobs/InboxPipeline/InboxWorker.php - About 1 hr to fix

      Function blindKeyRotation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function blindKeyRotation($headers, $payload)
    {
        $signature = is_array($headers['signature']) ? $headers['signature'][0] : $headers['signature'];
        $date = is_array($headers['date']) ? $headers['date'][0] : $headers['date'];
        if(!$signature) {
      Severity: Minor
      Found in app/Jobs/InboxPipeline/InboxWorker.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle()
    {
        $profile = null;
        $headers = $this->headers;
      Severity: Minor
      Found in app/Jobs/InboxPipeline/InboxWorker.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return;
          Severity: Major
          Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $this->verifySignature($headers, $payload);
                Severity: Major
                Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return true;
                  Severity: Major
                  Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return false;
                    Severity: Major
                    Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return;
                      Severity: Major
                      Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return false;
                          Severity: Major
                          Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return;
                            Severity: Major
                            Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return false;
                              Severity: Major
                              Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return;
                                Severity: Major
                                Found in app/Jobs/InboxPipeline/InboxWorker.php - About 30 mins to fix

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                          if(isset($bodyDecoded['object'])
            && is_array($bodyDecoded['object'])
            && isset($bodyDecoded['object']['attributedTo'])
        ) {
            $attr = Helpers::pluckval($bodyDecoded['object']['attributedTo']);
                                  Severity: Major
                                  Found in app/Jobs/InboxPipeline/InboxWorker.php and 2 other locations - About 2 hrs to fix
                                  app/Jobs/InboxPipeline/DeleteWorker.php on lines 138..153
                                  app/Jobs/InboxPipeline/InboxValidator.php on lines 125..140

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 134.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status