Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Profile.php

Summary

Maintainability
D
2 days
Test Coverage

Profile has 39 functions (exceeds 20 allowed). Consider refactoring.
Open

class Profile extends Model
{
    use HasSnowflakePrimary, SoftDeletes;

    /**
Severity: Minor
Found in app/Profile.php - About 5 hrs to fix

    File Profile.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace App;

use Auth, Cache, DB, Storage;
    Severity: Minor
    Found in app/Profile.php - About 3 hrs to fix

      Method getAudience has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getAudience($scope = false)
    {
        if($this->remote_url) {
            return [];
        }
      Severity: Minor
      Found in app/Profile.php - About 1 hr to fix

        Method avatarUrl has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function avatarUrl()
    {
        $url = Cache::remember('avatar:'.$this->id, 1209600, function () {
            $avatar = $this->avatar;
        Severity: Minor
        Found in app/Profile.php - About 1 hr to fix

          Function avatarUrl has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function avatarUrl()
    {
        $url = Cache::remember('avatar:'.$this->id, 1209600, function () {
            $avatar = $this->avatar;
          Severity: Minor
          Found in app/Profile.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return url(Storage::url($path));
          Severity: Major
          Found in app/Profile.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $url;
            Severity: Major
            Found in app/Profile.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return url('/storage/avatars/default.jpg');
              Severity: Major
              Found in app/Profile.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return url('/storage/avatars/default.jpg');
                Severity: Major
                Found in app/Profile.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $avatar->remote_url;
                  Severity: Major
                  Found in app/Profile.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return Storage::url($path);
                    Severity: Major
                    Found in app/Profile.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function followerCount($short = false)
    {
        $count = Cache::remember('profile:follower_count:'.$this->id, now()->addMonths(1), function() {
            if($this->domain == null && $this->user->settings->show_profile_follower_count == false) {
                return 0;
                      Severity: Major
                      Found in app/Profile.php and 1 other location - About 3 hrs to fix
                      app/Profile.php on lines 68..83

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 160.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function followingCount($short = false)
    {
        $count = Cache::remember('profile:following_count:'.$this->id, now()->addMonths(1), function() {
            if($this->domain == null && $this->user->settings->show_profile_following_count == false) {
                return 0;
                      Severity: Major
                      Found in app/Profile.php and 1 other location - About 3 hrs to fix
                      app/Profile.php on lines 85..99

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 160.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status