Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Services/CustomEmojiService.php

Summary

Maintainability
C
1 day
Test Coverage

Function import has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public static function import($url, $id = false)
    {
        if((bool) config_cache('federation.custom_emoji.enabled') == false) {
            return;
        }
Severity: Minor
Found in app/Services/CustomEmojiService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function import($url, $id = false)
    {
        if((bool) config_cache('federation.custom_emoji.enabled') == false) {
            return;
        }
Severity: Major
Found in app/Services/CustomEmojiService.php - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if(
                !$json ||
                !isset($json['id']) ||
                !isset($json['type']) ||
                $json['type'] !== 'Emoji' ||
    Severity: Critical
    Found in app/Services/CustomEmojiService.php - About 2 hrs to fix

      Avoid too many return statements within this method.
      Open

                      return;
      Severity: Major
      Found in app/Services/CustomEmojiService.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in app/Services/CustomEmojiService.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return;
          Severity: Major
          Found in app/Services/CustomEmojiService.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in app/Services/CustomEmojiService.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return;
              Severity: Major
              Found in app/Services/CustomEmojiService.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return;
                Severity: Major
                Found in app/Services/CustomEmojiService.php - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status