Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Services/LandingService.php

Summary

Maintainability
C
1 day
Test Coverage

Method get has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function get($json = true)
    {
        $activeMonth = Nodeinfo::activeUsersMonthly();

        $totalUsers = Cache::remember('api:nodeinfo:users', 43200, function () {
Severity: Major
Found in app/Services/LandingService.php - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

            return $res;
    Severity: Major
    Found in app/Services/LandingService.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return config_cache('app.rules') ?
                collect(json_decode(config_cache('app.rules'), true))
                    ->map(function ($rule, $key) {
                        $id = $key + 1;
      Severity: Major
      Found in app/Services/LandingService.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return json_encode($res);
        Severity: Major
        Found in app/Services/LandingService.php - About 30 mins to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  $rules = Cache::remember('api:v1:instance-data:rules', 604800, function () {
            return config_cache('app.rules') ?
                collect(json_decode(config_cache('app.rules'), true))
                    ->map(function ($rule, $key) {
                        $id = $key + 1;
          Severity: Major
          Found in app/Services/LandingService.php and 2 other locations - About 1 hr to fix
          app/Http/Controllers/Api/ApiV1Controller.php on lines 1619..1631
          app/Http/Controllers/Api/ApiV2Controller.php on lines 61..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $contactAccount = Cache::remember('api:v1:instance-data:contact', 604800, function () {
            if (config_cache('instance.admin.pid')) {
                return AccountService::getMastodon(config_cache('instance.admin.pid'), true);
            }
            $admin = User::whereIsAdmin(true)->first();
          Severity: Major
          Found in app/Services/LandingService.php and 2 other locations - About 1 hr to fix
          app/Http/Controllers/Api/ApiV1Controller.php on lines 1600..1609
          app/Http/Controllers/Api/ApiV2Controller.php on lines 51..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status