Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Services/LikeService.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method likedBy has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function likedBy($status)
    {
        $empty = [
            'username' => null,
            'others' => false
Severity: Minor
Found in app/Services/LikeService.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return $empty;
    Severity: Major
    Found in app/Services/LikeService.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $res;
      Severity: Major
      Found in app/Services/LikeService.php - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function add($profileId, $statusId)
    {
        $key = self::CACHE_KEY . $profileId . ':' . $statusId;
        Cache::increment('pf:services:likes:count:'.$statusId);
        Cache::forget('pf:services:likes:liked_by:'.$statusId);
        Severity: Minor
        Found in app/Services/LikeService.php and 1 other location - About 40 mins to fix
        app/Services/LikeService.php on lines 52..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function remove($profileId, $statusId)
    {
        $key = self::CACHE_KEY . $profileId . ':' . $statusId;
        Cache::decrement('pf:services:likes:count:'.$statusId);
        Cache::forget('pf:services:likes:liked_by:'.$statusId);
        Severity: Minor
        Found in app/Services/LikeService.php and 1 other location - About 40 mins to fix
        app/Services/LikeService.php on lines 15..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status