Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Services/NotificationService.php

Summary

Maintainability
F
4 days
Test Coverage

Function getMaxMastodon has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getMaxMastodon($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMaxId($id, $start, $limit);

        if (empty($ids)) {
Severity: Minor
Found in app/Services/NotificationService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getMinMastodon has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getMinMastodon($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMinId($id, $start, $limit);

        if (empty($ids)) {
Severity: Minor
Found in app/Services/NotificationService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File NotificationService.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Services;

use App\Jobs\InternalPipeline\NotificationEpochUpdatePipeline;
Severity: Minor
Found in app/Services/NotificationService.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            return $notification;
    Severity: Major
    Found in app/Services/NotificationService.php - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getMaxMastodon($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMaxId($id, $start, $limit);

        if (empty($ids)) {
      Severity: Major
      Found in app/Services/NotificationService.php and 1 other location - About 1 day to fix
      app/Services/NotificationService.php on lines 152..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 315.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getMinMastodon($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMinId($id, $start, $limit);

        if (empty($ids)) {
      Severity: Major
      Found in app/Services/NotificationService.php and 1 other location - About 1 day to fix
      app/Services/NotificationService.php on lines 116..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 315.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getMin($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMinId($id, $start, $limit);

        if (empty($ids)) {
      Severity: Major
      Found in app/Services/NotificationService.php and 1 other location - About 1 hr to fix
      app/Services/NotificationService.php on lines 78..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getMax($id = false, $start = 0, $limit = 10)
    {
        $ids = self::getRankedMaxId($id, $start, $limit);

        if (empty($ids)) {
      Severity: Major
      Found in app/Services/NotificationService.php and 1 other location - About 1 hr to fix
      app/Services/NotificationService.php on lines 97..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status