pixelfed/pixelfed

View on GitHub
app/Services/SearchApiV2Service.php

Summary

Maintainability
F
4 days
Test Coverage

Function resolveQuery has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

    protected function resolveQuery()
    {
        $default = [
            'accounts' => [],
            'hashtags' => [],
Severity: Minor
Found in app/Services/SearchApiV2Service.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolveQuery has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function resolveQuery()
    {
        $default = [
            'accounts' => [],
            'hashtags' => [],
Severity: Major
Found in app/Services/SearchApiV2Service.php - About 5 hrs to fix

    File SearchApiV2Service.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace App\Services;
    
    use App\Hashtag;
    Severity: Minor
    Found in app/Services/SearchApiV2Service.php - About 4 hrs to fix

      Method run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function run($query)
          {
              $this->query = $query;
              $q = urldecode($query->input('q'));
      
      
      Severity: Minor
      Found in app/Services/SearchApiV2Service.php - About 1 hr to fix

        Method accounts has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function accounts($initalQuery = false)
            {
                $mastodonMode = self::$mastodonMode;
                $user = request()->user();
                $limit = $this->query->input('limit') ?? 20;
        Severity: Minor
        Found in app/Services/SearchApiV2Service.php - About 1 hr to fix

          Method hashtags has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function hashtags()
              {
                  $mastodonMode = self::$mastodonMode;
                  $q = $this->query->input('q');
                  $limit = $this->query->input('limit') ?? 20;
          Severity: Minor
          Found in app/Services/SearchApiV2Service.php - About 1 hr to fix

            Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function run($query)
                {
                    $this->query = $query;
                    $q = urldecode($query->input('q'));
            
            
            Severity: Minor
            Found in app/Services/SearchApiV2Service.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                                return $default;
            Severity: Major
            Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                              return $default;
              Severity: Major
              Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return [
                            'accounts' => $this->accounts(),
                            'hashtags' => $this->hashtags(),
                            'statuses' => $this->statuses(),
                        ];
                Severity: Major
                Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return $default;
                  Severity: Major
                  Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                                    return $default;
                    Severity: Major
                    Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return $default;
                      Severity: Major
                      Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return $default;
                        Severity: Major
                        Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                      return $default;
                          Severity: Major
                          Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return [
                                                'accounts' => [],
                                                'hashtags' => [],
                                                'statuses' => [],
                                            ];
                            Severity: Major
                            Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return $default;
                              Severity: Major
                              Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                        return $default;
                                Severity: Major
                                Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                                  return $default;
                                  Severity: Major
                                  Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                            return [
                                                                'accounts' => [],
                                                                'hashtags' => [],
                                                                'statuses' => [],
                                                            ];
                                    Severity: Major
                                    Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                                      return $default;
                                      Severity: Major
                                      Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                        return $default;
                                        Severity: Major
                                        Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                              return $default;
                                          Severity: Major
                                          Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                                        return $default;
                                            Severity: Major
                                            Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                                          return [
                                                                              'accounts' => [],
                                                                              'hashtags' => [],
                                                                              'statuses' => [],
                                                                          ];
                                              Severity: Major
                                              Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                                    return $default;
                                                Severity: Major
                                                Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                              return [
                                                                  'accounts' => [],
                                                                  'hashtags' => [],
                                                                  'statuses' => $this->statusesById(),
                                                              ];
                                                  Severity: Major
                                                  Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                        return $default;
                                                    Severity: Major
                                                    Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                                      return $default;
                                                      Severity: Major
                                                      Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                            return $default;
                                                        Severity: Major
                                                        Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                              return $default;
                                                          Severity: Major
                                                          Found in app/Services/SearchApiV2Service.php - About 30 mins to fix

                                                            There are no issues that match your filters.

                                                            Category
                                                            Status