pixelfed/pixelfed

View on GitHub

Showing 612 of 615 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                ->whereToId($profile)
                ->with(['author','status'])
                ->whereIsHidden(false)
                ->groupBy('from_id')
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 44..81
app/Http/Controllers/DirectMessageController.php on lines 85..121
app/Http/Controllers/DirectMessageController.php on lines 125..162
app/Http/Controllers/DirectMessageController.php on lines 207..243
app/Http/Controllers/DirectMessageController.php on lines 247..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                ->whereFromId($profile)
                ->with(['author','status'])
                ->groupBy('to_id')
                ->orderBy('createdAt', 'desc')
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 44..81
app/Http/Controllers/DirectMessageController.php on lines 85..121
app/Http/Controllers/DirectMessageController.php on lines 125..162
app/Http/Controllers/DirectMessageController.php on lines 166..203
app/Http/Controllers/DirectMessageController.php on lines 247..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                ->whereFromId($profile)
                ->with(['author','status'])
                ->orderBy('id', 'desc')
                ->when($page, function($q, $page) {
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 44..81
app/Http/Controllers/DirectMessageController.php on lines 125..162
app/Http/Controllers/DirectMessageController.php on lines 166..203
app/Http/Controllers/DirectMessageController.php on lines 207..243
app/Http/Controllers/DirectMessageController.php on lines 247..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                ->whereToId($profile)
                ->with(['author','status'])
                ->whereIsHidden(false)
                ->when($page, function($q, $page) {
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 85..121
app/Http/Controllers/DirectMessageController.php on lines 125..162
app/Http/Controllers/DirectMessageController.php on lines 166..203
app/Http/Controllers/DirectMessageController.php on lines 207..243
app/Http/Controllers/DirectMessageController.php on lines 247..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                ->whereToId($profile)
                ->with(['author','status'])
                ->whereIsHidden(true)
                ->orderBy('id', 'desc')
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 44..81
app/Http/Controllers/DirectMessageController.php on lines 85..121
app/Http/Controllers/DirectMessageController.php on lines 166..203
app/Http/Controllers/DirectMessageController.php on lines 207..243
app/Http/Controllers/DirectMessageController.php on lines 247..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

                $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                ->whereToId($profile)
                ->with(['author','status'])
                ->whereIsHidden(true)
                ->groupBy('from_id')
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
app/Http/Controllers/DirectMessageController.php on lines 44..81
app/Http/Controllers/DirectMessageController.php on lines 85..121
app/Http/Controllers/DirectMessageController.php on lines 125..162
app/Http/Controllers/DirectMessageController.php on lines 166..203
app/Http/Controllers/DirectMessageController.php on lines 207..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 256.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function FakeBlobBuilder has 200 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function FakeBlobBuilder () {
    function isDataView (obj) {
      return obj && DataView.prototype.isPrototypeOf(obj)
    }
    function bufferClone (buf) {
Severity: Major
Found in resources/assets/js/polyfill.js - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if($status->uri == null) {
                        $media = $status->media;
                        $ai = new AccountInterstitial;
                        $ai->user_id = $status->profile->user_id;
                        $ai->type = 'post.cw';
    Severity: Major
    Found in app/Http/Controllers/InternalApiController.php and 1 other location - About 7 hrs to fix
    app/Http/Controllers/InternalApiController.php on lines 287..313

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 241.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if($status->uri == null) {
                        $media = $status->media;
                        $ai = new AccountInterstitial;
                        $ai->user_id = $status->profile->user_id;
                        $ai->type = 'post.unlist';
    Severity: Major
    Found in app/Http/Controllers/InternalApiController.php and 1 other location - About 7 hrs to fix
    app/Http/Controllers/InternalApiController.php on lines 214..240

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 241.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File AccountController.php has 477 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace App\Http\Controllers;
    
    use Auth;
    Severity: Minor
    Found in app/Http/Controllers/AccountController.php - About 7 hrs to fix

      ApiV1Controller has 52 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ApiV1Controller extends Controller
      {
          protected $fractal;
      
          public function __construct()
      Severity: Major
      Found in app/Http/Controllers/Api/ApiV1Controller.php - About 7 hrs to fix

        File web.php has 471 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        Route::domain(config('pixelfed.domain.admin'))->prefix('i/admin')->group(function () {
            Route::redirect('/', '/dashboard');
            Route::redirect('timeline', config('app.url').'/timeline');
        Severity: Minor
        Found in routes/web.php - About 7 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function searchLocation(Request $request)
              {
                  abort_if(!Auth::check(), 403);
                  $this->validate($request, [
                      'q' => 'required|string|max:100'
          Severity: Major
          Found in app/Http/Controllers/ComposeController.php and 1 other location - About 7 hrs to fix
          app/Http/Controllers/ApiController.php on lines 83..107

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 229.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function composeLocationSearch(Request $request)
              {
                  abort_if(!Auth::check(), 403);
                  $this->validate($request, [
                      'q' => 'required|string|max:100'
          Severity: Major
          Found in app/Http/Controllers/ApiController.php and 1 other location - About 7 hrs to fix
          app/Http/Controllers/ComposeController.php on lines 308..332

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 229.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function statusFirstOrFetch has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function statusFirstOrFetch($url, $replyTo = false)
              {
                  $url = self::validateUrl($url);
                  if($url == false) {
                      return;
          Severity: Minor
          Found in app/Util/ActivityPub/Helpers.php - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getData has 173 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getData(Request $request)
              {
                  abort_if(now()->gt('2021-03-01 00:00:00'), 404);
                  abort_if(config('database.default') != 'mysql', 404);
          
          
          Severity: Major
          Found in app/Http/Controllers/SeasonalController.php - About 6 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
            
            namespace App\Jobs\StoryPipeline;
            
            use App\Story;
            Severity: Major
            Found in app/Jobs/StoryPipeline/StoryReplyDeliver.php and 1 other location - About 6 hrs to fix
            app/Jobs/StoryPipeline/StoryReactionDeliver.php on lines 1..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 222.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
            
            namespace App\Jobs\StoryPipeline;
            
            use App\Story;
            Severity: Major
            Found in app/Jobs/StoryPipeline/StoryReactionDeliver.php and 1 other location - About 6 hrs to fix
            app/Jobs/StoryPipeline/StoryReplyDeliver.php on lines 1..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 222.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method modAction has 156 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function modAction(Request $request)
                {
                    abort_unless(Auth::user()->is_admin, 400);
                    $this->validate($request, [
                        'action' => [
            Severity: Major
            Found in app/Http/Controllers/InternalApiController.php - About 6 hrs to fix

              File StoryComposeController.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              namespace App\Http\Controllers;
              
              use Illuminate\Http\Request;
              Severity: Minor
              Found in app/Http/Controllers/StoryComposeController.php - About 6 hrs to fix
                Severity
                Category
                Status
                Source
                Language