Sign upLogin

pluf/core

View on GitHub
Star
src/Process/HttpBodyToEntities.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getContentType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getContentType(ServerRequestInterface $request): string
    {
        $contentTypes = $request->getHeader("Content-Type") ?? [];

        $parsedContentType = 'application/json';
Severity: Minor
Found in src/Process/HttpBodyToEntities.php - About 1 hr to fix

    The method __construct has a boolean flag argument $multi, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct(string $class, bool $multi = true, string $name = "entities")
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method getContentType uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $type = "array";
        }
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
    Open

        protected string $class;
    Severity: Critical
    Found in src/Process/HttpBodyToEntities.php by phan

    Avoid excessively long variable names like $modelDescriptionRepository. Keep variable name length under 20.
    Open

        public function generateEntities($type, $modelDescriptionRepository, $data)
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $modelDescriptionRepository. Keep variable name length under 20.
    Open

        public function __invoke(ModelDescriptionRepository $modelDescriptionRepository, ServerRequestInterface $request, UnitTrackerInterface $unitTracker)
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $contentTypesWithParsedBodies. Keep variable name length under 20.
    Open

            $contentTypesWithParsedBodies = [
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Expected 1 blank line at end of file; 2 found
    Open

    }
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpcodesniffer

    Line exceeds 120 characters; contains 152 characters
    Open

        public function __invoke(ModelDescriptionRepository $modelDescriptionRepository, ServerRequestInterface $request, UnitTrackerInterface $unitTracker)
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status