pmonks/alfresco-bulk-import

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                if (model.aspects != null && model.aspects.size() > 0)
                {
                    for (AspectDefinition aspect : model.aspects)
                    {
                        result.append(classDefinitionToString(aspect));

Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java and 1 other location - About 45 mins to fix

Read up
Read up

amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java on lines 155..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                if (model.types != null && model.types.size() > 0)
                {
                    for (TypeDefinition type : model.types)
                    {
                        result.append(classDefinitionToString(type));

Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java and 1 other location - About 45 mins to fix

Read up
Read up

amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java on lines 168..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Avoid deeply nested control flow statements.
Open

                        if (propertyDefinition != null)
                        {
                            if (propertyDefinition.isMultiValued())
                            {
                                // Multi-valued property

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/AbstractMapBasedMetadataLoader.java - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        for (ConstraintDefinition propertyConstraint : propertyConstraints)
                        {
                            result.append(propertyConstraint.getName().toPrefixString());
                            result.append(", ");
                        }

Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        if (lastVersion.getContentFile() != null)
                        {
                            scanDirectory(status,
                                          callback,
                                          sourceDirectory,

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 45 mins to fix

Method `executeImpl` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected Map<String, Object> executeImpl(final WebScriptRequest request, final Status status, final Cache cache)
    {
        Map<String, Object> result = null;

Found in amp/src/main/java/org/alfresco/extension/bulkimport/webscripts/BulkImportUIWebScript.java - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        for (final String aspectName : aspectNames)
                        {
                            result.addAspect(aspectName.trim());
                        }

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/AbstractMapBasedMetadataLoader.java - About 45 mins to fix

Method `calculateType` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private final static String calculateType(final MetadataLoader metadataLoader,
                                              final File           contentFile,
                                              final File           metadataFile,
                                              final String         typeFolder,
                                              final String         typeFile)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportItemVersion.java - About 35 mins to fix

Method `importVersion` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private final void importVersion(final NodeRef               nodeRef,
                                     final BulkImportItemVersion previousVersion,
                                     final BulkImportItemVersion version,
                                     final boolean               dryRun,
                                     final boolean               onlyOneVersion)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java - About 35 mins to fix

Method `importBatch` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public final void importBatch(final String  userId,
                                  final NodeRef target,
                                  final Batch   batch,
                                  final boolean replaceExisting,
                                  final boolean dryRun)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java - About 35 mins to fix

Method `importBatch` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void importBatch(String  userId,
                            NodeRef target,
                            Batch   batch,
                            boolean replaceExisting,
                            boolean dryRun)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporter.java - About 35 mins to fix

Method `scanDirectory` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void scanDirectory(final BulkImportSourceStatus status,
                               final BulkImportCallback     callback,
                               final File                   sourceDirectory,
                               final File                   directory,
                               final boolean                submitFiles)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 35 mins to fix

Method `analyseDirectory` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Pair<List<FilesystemBulkImportItem>, List<FilesystemBulkImportItem>> analyseDirectory(final File sourceDirectory, final File directory)
        throws InterruptedException
    {
        // PRECONDITIONS
        if (sourceDirectory == null) throw new IllegalArgumentException("sourceDirectory cannot be null.");

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/DirectoryAnalyser.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `importBatchImpl` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private final void importBatchImpl(final NodeRef target,
                                       final Batch   batch,
                                       final boolean replaceExisting,
                                       final boolean dryRun)
        throws InterruptedException

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `shouldFilter` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean shouldFilter(final FilesystemBulkImportItem item)
    {
        boolean result = false;

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/importfilters/HiddenFileFilter.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `calculateType` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private final static String calculateType(final MetadataLoader metadataLoader,
                                              final File           contentFile,
                                              final File           metadataFile,
                                              final String         typeFolder,
                                              final String         typeFile)

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportItemVersion.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `init` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void init(final BulkImportSourceStatus importStatus, final Map<String, List<String>> parameters)
    {
        final List<String> sourceDirectoryParameterValues = parameters.get(PARAMETER_SOURCE_DIRECTORY);
        String             sourceDirectoryName            = null;

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `logStatusInfo` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private final void logStatusInfo()
    {
        if (info(log))
        {
            try

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/Scanner.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `submit` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    @SuppressWarnings({"rawtypes", "unchecked"})
    public synchronized void submit(final BulkImportItem item)
        throws InterruptedException
    {

Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/Scanner.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `categoriseFiles` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private Map<String, SortedMap<BigDecimal, Pair<File, File>>> categoriseFiles(final File[] directoryListing)
        throws InterruptedException
    {
        Map<String, SortedMap<BigDecimal, Pair<File, File>>> result = null;

Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/DirectoryAnalyser.java - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading