Sign upLogin

pmonks/alfresco-bulk-import

View on GitHub
Star

Showing 111 of 111 total issues

Method importBatchImpl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private final void importBatchImpl(final NodeRef target,
                                       final Batch   batch,
                                       final boolean replaceExisting,
                                       final boolean dryRun)
        throws InterruptedException
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stateToColour has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function stateToColour(state)
{
  var result = "black";

  // Note: these names must line up with the processing state values returned by the server
Severity: Minor
Found in amp/src/main/amp/web/scripts/bulkimport/bulkimport.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sizeInBytes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public long sizeInBytes()
    {
        long                  result   = 0L;
        final NavigableSet<T> versions = getVersions();
Severity: Minor
Found in api/src/main/java/org/alfresco/extension/bulkimport/source/AbstractBulkImportItem.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (info(log)) info(log, "[DRY RUN] Would have created " + (isMajor ? "major" : "minor") + " version of node '" + String.valueOf(nodeRef) + "'.");
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java and 1 other location - About 30 mins to fix
amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java on lines 469..469

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (trace(log)) trace(log, "Creating " + (isMajor ? "major" : "minor") + " version of node '" + String.valueOf(nodeRef) + "'.");
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java and 1 other location - About 30 mins to fix
amp/src/main/java/org/alfresco/extension/bulkimport/impl/BatchImporterImpl.java on lines 458..458

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private final boolean filter(final FilesystemBulkImportItem item)
    {
        boolean result = false;
        
        if (importFilters != null)
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isInDirectoryImpl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private final static boolean isInDirectoryImpl(final File directory, final File suspectedChild)
    {
        boolean result = false;
        
        if (directory != null && suspectedChild != null)
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemSourceUtils.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method constructImportItemVersions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private final NavigableSet<FilesystemBulkImportItemVersion> constructImportItemVersions(final SortedMap<BigDecimal,Pair<File,File>> itemVersions)
        throws InterruptedException
    {
        // PRECONDITIONS
        if (itemVersions        == null) throw new IllegalArgumentException("itemVersions cannot be null.");
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/DirectoryAnalyser.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createQName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public final static QName createQName(final ServiceRegistry serviceRegistry, final String qname)
    {
        QName result = null;
        
        if (qname != null)
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/Utils.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method numberOfAspects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public int numberOfAspects()
    {
        int                   result   = 0;
        final NavigableSet<T> versions = getVersions();
Severity: Minor
Found in api/src/main/java/org/alfresco/extension/bulkimport/source/AbstractBulkImportItem.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method numberOfMetadataProperties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public int numberOfMetadataProperties()
    {
        int                   result   = 0;
        final NavigableSet<T> versions = getVersions();
Severity: Minor
Found in api/src/main/java/org/alfresco/extension/bulkimport/source/AbstractBulkImportItem.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language