Sign upLogin

polyfony-inc/polyfony

View on GitHub
Star
Private/Polyfony/Query.php

Summary

Maintainability
D
2 days
Test Coverage

Function buildQuery has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    private function buildQuery() :void {

        // if the action is missing
        if(!$this->Action) { Throw new Exception('Query->buildQuery() : Missing action'); }
        // if action anything but query
Severity: Minor
Found in Private/Polyfony/Query.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Query has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class Query extends Query\Conditions {
    
    // debugging methods (for the Profiler)
    public function getQuery() {
        return $this->Query;
Severity: Minor
Found in Private/Polyfony/Query.php - About 3 hrs to fix

File Query.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
 
namespace Polyfony;
use \PDO;
use Polyfony\Query\Convert as Convert;
Severity: Minor
Found in Private/Polyfony/Query.php - About 3 hrs to fix

Method buildQuery has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildQuery() :void {

        // if the action is missing
        if(!$this->Action) { Throw new Exception('Query->buildQuery() : Missing action'); }
        // if action anything but query
Severity: Major
Found in Private/Polyfony/Query.php - About 2 hrs to fix

Function detectActionAndTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function detectActionAndTable() {
        // detetect the action
        $action = substr($this->Query, 0, 6);
        // if action can alter a table (INSERT, UPDATE, DELETE)
        if(in_array($action, array('INSERT', 'UPDATE', 'DELETE', 'SELECT'))) {
Severity: Minor
Found in Private/Polyfony/Query.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function join(
        string $table, 
        string $match, 
        string $against
    ) :self {
Severity: Major
Found in Private/Polyfony/Query.php and 2 other locations - About 1 hr to fix
Private/Polyfony/Query.php on lines 187..200
Private/Polyfony/Query.php on lines 203..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function leftJoin(
        string $table, 
        string $match, 
        string $against
    ) :self {
Severity: Major
Found in Private/Polyfony/Query.php and 2 other locations - About 1 hr to fix
Private/Polyfony/Query.php on lines 171..184
Private/Polyfony/Query.php on lines 203..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function rightJoin(
        string $table, 
        string $match, 
        string $against
    ) :self {
Severity: Major
Found in Private/Polyfony/Query.php and 2 other locations - About 1 hr to fix
Private/Polyfony/Query.php on lines 171..184
Private/Polyfony/Query.php on lines 187..200

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status