prawnpdf/prawn-table

View on GitHub
lib/prawn/table/cell.rb

Summary

Maintainability
F
3 days
Test Coverage

Class Cell has 71 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Cell

      # Amount of dead space (in PDF points) inside the borders but outside the
      # content. Padding defaults to 5pt.
      #
Severity: Major
Found in lib/prawn/table/cell.rb - About 1 day to fix

    File cell.rb has 439 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'date'
    module Prawn
      class Document
    
        # @group Experimental API
    Severity: Minor
    Found in lib/prawn/table/cell.rb - About 6 hrs to fix

      Method draw_borders has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def draw_borders(pt)
              x, y = pt
      
              @pdf.mask(:line_width, :stroke_color) do
                @borders.each do |border|
      Severity: Minor
      Found in lib/prawn/table/cell.rb - About 1 hr to fix

        Method draw_borders has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def draw_borders(pt)
                x, y = pt
        
                @pdf.mask(:line_width, :stroke_color) do
                  @borders.each do |border|
        Severity: Minor
        Found in lib/prawn/table/cell.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method make has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.make(pdf, content, options={})
                at = options.delete(:at) || [0, pdf.cursor]
        
                return Cell::Image.new(pdf, at, content) if content.is_a?(Hash) && content[:image]
        
        
        Severity: Minor
        Found in lib/prawn/table/cell.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def border_width=(width)
                @border_widths = case
                when width.nil?
                  ["000000"] * 4
                when Numeric === width # all widths
        Severity: Major
        Found in lib/prawn/table/cell.rb and 1 other location - About 2 hrs to fix
        lib/prawn/table/cell.rb on lines 538..552

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def border_color=(color)
                @border_colors = case
                when color.nil?
                  ["000000"] * 4
                when String === color # all colors
        Severity: Major
        Found in lib/prawn/table/cell.rb and 1 other location - About 2 hrs to fix
        lib/prawn/table/cell.rb on lines 596..610

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def width
                return width_ignoring_span if @colspan == 1 && @rowspan == 1
        
                # We're in a span group; get the maximum width per column (including
                # the master cell) and sum each column.
        Severity: Minor
        Found in lib/prawn/table/cell.rb and 1 other location - About 1 hr to fix
        lib/prawn/table/cell.rb on lines 321..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def height
                return height_ignoring_span if @colspan == 1 && @rowspan == 1
        
                # We're in a span group; get the maximum height per row (including the
                # master cell) and sum each row.
        Severity: Minor
        Found in lib/prawn/table/cell.rb and 1 other location - About 1 hr to fix
        lib/prawn/table/cell.rb on lines 264..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def min_width
                return min_width_ignoring_span if @colspan == 1
        
                # Sum up the largest min-width from each column, including myself.
                min_widths = Hash.new(0)
        Severity: Minor
        Found in lib/prawn/table/cell.rb and 1 other location - About 50 mins to fix
        lib/prawn/table/cell.rb on lines 97..108

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def max_width
                return max_width_ignoring_span if @colspan == 1
        
                # Sum the smallest max-width from each column in the group, including
                # myself.
        Severity: Minor
        Found in lib/prawn/table/cell.rb and 1 other location - About 50 mins to fix
        lib/prawn/table/cell.rb on lines 68..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status