presidentbeef/brakeman

View on GitHub
lib/brakeman/checks/check_nested_attributes.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
87%
require 'brakeman/checks/base_check'

#Check for vulnerability in nested attributes in Rails 2.3.9 and 3.0.0
#http://groups.google.com/group/rubyonrails-security/browse_thread/thread/f9f913d328dafe0c
class Brakeman::CheckNestedAttributes < Brakeman::BaseCheck
  Brakeman::Checks.add self

  @description = "Checks for nested attributes vulnerability in Rails 2.3.9 and 3.0.0"

  def run_check
    version = rails_version

    if (version == "2.3.9" or version == "3.0.0") and uses_nested_attributes?
      message = msg("Vulnerability in nested attributes ", msg_cve("CVE-2010-3933"), ". Upgrade to ")

      if version == "2.3.9"
        message << msg_version("2.3.10")
      else
        message << msg_version("3.0.1")
      end

      warn :warning_type => "Nested Attributes",
        :warning_code => :CVE_2010_3933,
        :message => message,
        :confidence => :high,
        :gem_info => gemfile_or_environment,
        :link_path => "https://groups.google.com/d/topic/rubyonrails-security/-fkT0yja_gw/discussion",
        :cwe_id => [20]
    end
  end

  def uses_nested_attributes?
    active_record_models.each do |_name, model|
      return true if model.options[:accepts_nested_attributes_for]
    end

    false
  end
end