Sign upLogin

prey/prey-node-client

View on GitHub
Star

Showing 551 of 551 total issues

Function start has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

Operetta.prototype.start = function(callback) {
  var operetta = this;

  // if has subcommands and none was passed, show options
  if (this.args.length == 0 && Object.keys(this.commands).length > 0)
Severity: Minor
Found in lib/conf/utils/operetta.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_settings has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const update_settings = (obj) => {
  logger.debug('Syncing settings.');

  function process(values, locals = false) {
    Object.keys(values).forEach((key) => {
Severity: Minor
Found in lib/agent/control-panel/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_access_points_list has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

exports.get_access_points_list = (callback) => {
  let cmd;
  let parser;
  let list = [];
Severity: Minor
Found in lib/agent/providers/network/windows.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find_logged_user has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

exports.find_logged_user = function(callback) {
  var done = function(err, stdout) {
    if (err) {
      if (typeof callback !== 'function')
        return;
Severity: Minor
Found in lib/system/windows/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function download_verify has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

releases.download_verify = function(version, cb) {
  if (os_name === 'mac'){
    cp.exec('sysctl sysctl.proc_translated', (err, stdout) => {
      if(err) {
        download_file(version, arch, cb);
Severity: Minor
Found in lib/package.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function format_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

var format_data = function(data, cb) {
  var body = [],
      attachments = [];

  for (var key in data) {
Severity: Minor
Found in lib/agent/transports/smtp/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  var cls = function Geopoint() {
    this.altitudeReferenceSystem = new AltitudeReferenceSystem();
    this.geoshapeType = new GeoshapeType();
    this.spatialReferenceId = new Number();
    this.position = new BasicGeoposition();
Severity: Major
Found in lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js and 3 other locations - About 1 hr to fix
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 73..78
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 80..85
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 87..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

var cls = function Geopoint(position, altitudeReferenceSystem, spatialReferenceId) {
      this.altitudeReferenceSystem = new AltitudeReferenceSystem();
      this.geoshapeType = new GeoshapeType();
      this.spatialReferenceId = new Number();
      this.position = new BasicGeoposition();
Severity: Major
Found in lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js and 3 other locations - About 1 hr to fix
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 66..71
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 73..78
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 80..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def call_prey_config(self, action, opts):
    return self.run_command(PREY_CONFIG + ' ' + action + ' ' + opts)
Severity: Major
Found in lib/conf/gui/linux/prey-config.py and 1 other location - About 1 hr to fix
lib/conf/gui/linux/prey-config3.py on lines 331..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def call_prey_config(self, action, opts):
        return self.run_command(PREY_CONFIG + " " + action + " " + opts)
Severity: Major
Found in lib/conf/gui/linux/prey-config3.py and 1 other location - About 1 hr to fix
lib/conf/gui/linux/prey-config.py on lines 297..298

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

var cls = function Geopoint(position) {
      this.altitudeReferenceSystem = new AltitudeReferenceSystem();
      this.geoshapeType = new GeoshapeType();
      this.spatialReferenceId = new Number();
      this.position = new BasicGeoposition();
Severity: Major
Found in lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js and 3 other locations - About 1 hr to fix
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 66..71
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 80..85
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 87..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

var cls = function Geopoint(position, altitudeReferenceSystem) {
      this.altitudeReferenceSystem = new AltitudeReferenceSystem();
      this.geoshapeType = new GeoshapeType();
      this.spatialReferenceId = new Number();
      this.position = new BasicGeoposition();
Severity: Major
Found in lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js and 3 other locations - About 1 hr to fix
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 66..71
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 73..78
lib/agent/providers/geo/win32/windows.devices.geolocation/lib/NodeRT_Windows_Devices_Geolocation.d.js on lines 87..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get_battery_status has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.get_battery_status = function(callback){

  var cmd = 'upower --dump';

  exec(cmd, function(err, stdout) {
Severity: Minor
Found in lib/agent/providers/indicators/linux.js - About 1 hr to fix

    Function cp has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var cp = run_as_user(opts, function(err, out) {
    if (err) return cb(err);

    try {
      var files = JSON.parse(out);
    Severity: Minor
    Found in lib/agent/providers/files/index.js - About 1 hr to fix

      Function fetch has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const fetch = (key, section, value) => {
    wmic.get_value(section, value, null, (err, resp) => {
      let res = resp;
      if (key === 'device_type') {
        res = err ? 'Desktop' : 'Laptop';
      Severity: Minor
      Found in lib/agent/providers/hardware/windows.js - About 1 hr to fix

        Function compareField has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const compareField = (current, storedToCompare) => {
    const stored = storedToCompare;
    if (stored instanceof Array) {
      if (!current || (current.length > stored.length)) {
        diffCount += 1;
        Severity: Minor
        Found in lib/agent/providers/hardware/index.js - About 1 hr to fix

          Function saveDataToDb has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const saveDataToDb = (dataToSave, cb) => {
  try {
    // eslint-disable-next-line consistent-return
    getDataDb('preyconf', (err, stored) => {
      if (err) {
          Severity: Minor
          Found in lib/agent/utils/prey-configuration/preyconf.js - About 1 hr to fix

            Function install has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            package.install = function(zip, dest, cb) {

  if (!zip.match(/prey-(\w+)-([\d\.]+)/))
    return cb(new Error("This doesn't look like a Prey package: " + zip));
            Severity: Minor
            Found in lib/package.js - About 1 hr to fix

              Function tryToSendNew has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const tryToSendNew = () => {
  // eslint-disable-next-line array-callback-return, consistent-return
  messagesData = messagesData.reduce((acc, element) => {
    const timeObj = element.time;
    if (((new Date()).getTime() - timeObj) >= element.timeLimitPerMessage) {
              Severity: Minor
              Found in lib/agent/socket/index.js - About 1 hr to fix

                Function getRestartsPreyconf has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const getRestartsPreyconf = (callback) => {
  try {
    // eslint-disable-next-line consistent-return
    getDataDb('restarts_preyconf', (err, stored) => {
      if (err) {
                Severity: Minor
                Found in lib/agent/utils/prey-configuration/validationpreyconf.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language