Sign upLogin

princelab/mspire

View on GitHub
Star
lib/mspire/ident/pepxml.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method to_xml has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def to_xml(opts={})
    opts ||= {}
    if opts.is_a?(String) 
      opts = ( opts.match(/\.xml$/) ?  {:outfile => opts} : {:outdir => opts } )
    end
Severity: Minor
Found in lib/mspire/ident/pepxml.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method simple_search_hits has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.simple_search_hits(file, &block)
    hit_values = File.open(file) do |io|
      doc = Nokogiri::XML.parse(io, nil, nil, Nokogiri::XML::ParseOptions::DEFAULT_XML | Nokogiri::XML::ParseOptions::NOBLANKS | Nokogiri::XML::ParseOptions::STRICT)
      # we can work with namespaces, or just remove them ...
      doc.remove_namespaces!
Severity: Minor
Found in lib/mspire/ident/pepxml.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status