Sign upLogin

princelab/mspire

View on GitHub
Star
lib/mspire/ident/pepxml/search_summary.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method to_xml has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def to_xml(builder=nil)
    # TODO: out_data and out_data_type are optional in later pepxml versions...
    # should work that in...
    attrs = [:base_name, :search_engine, :precursor_mass_type, :fragment_mass_type, :out_data_type, :out_data, :search_id]
    hash = Hash[ attrs.map {|at| v=send(at) ; [at, v] if v }.compact ]
Severity: Minor
Found in lib/mspire/ident/pepxml/search_summary.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status